Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-05 Thread Brian Masney
On Tue, Mar 03, 2020 at 09:27:50PM -0500, Jonathan Marek wrote: > modetest should be printing "freq: 60.0Hz", so definitely something wrong > there. Though I guess you have another problem since I would expect the > patch to drop it to 30 and not 13.5. So I reverted the following three commits rel

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-05 Thread Jonathan Marek
The msm DSI driver does predate the addition of those fields and doesn't use them at all. Seems like it would be a bit of a hack too, since the frequency we want to use is not the "real limits of the hardware".. On 3/4/20 4:10 AM, Linus Walleij wrote: On Mon, Mar 2, 2020 at 9:49 PM Jonathan

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-05 Thread Brian Masney
On Tue, Mar 03, 2020 at 10:04:56PM -0500, Jonathan Marek wrote: > If I have time to kill over the weekend I'll do a new rebase of my Nexus 5 > patches (my last rebase was back in August on 5.2, and the panel was working > correctly at 60Hz back then). That would be great if you have time to look a

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-04 Thread Linus Walleij
On Wed, Mar 4, 2020 at 2:17 PM Jonathan Marek wrote: [hs_rate / lp_rate] > The msm DSI driver does predate the addition of those fields and doesn't > use them at all. I think it would be benficient to switch to these fields, because then the .clock field (dot/pixelclock) is not abused to contai

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-04 Thread Linus Walleij
On Mon, Mar 2, 2020 at 9:49 PM Jonathan Marek wrote: > This is a command mode panel and the the msm/mdp5 driver uses the > vrefresh field for the actual refresh rate, while the dotclock field is > used for the DSI clocks. The dotclock needed to be a bit higher than > necessary otherwise the panel

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Brian Masney
On Tue, Mar 03, 2020 at 08:04:05AM -0500, Jonathan Marek wrote: > What Xorg prints doesn't mean anything. I don't think there will be errors > in dmesg, you need to run something that does pageflips as fast as possible > and see that the refresh rate is still 60. (modetest with -v, glmark-drm are >

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Brian Masney
On Mon, Mar 02, 2020 at 10:36:54PM -0500, Jonathan Marek wrote: > Another thing: did you verify that the panel still runs at 60hz (and not > dropping frames to 30hz)? IIRC that was the behavior with lower clock. Yes, the panel is running at 60 HZ according to the Xorg log with Ville's patch applie

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
What Xorg prints doesn't mean anything. I don't think there will be errors in dmesg, you need to run something that does pageflips as fast as possible and see that the refresh rate is still 60. (modetest with -v, glmark-drm are examples) On 3/3/20 7:26 AM, Brian Masney wrote: On Mon, Mar 02,

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
If I have time to kill over the weekend I'll do a new rebase of my Nexus 5 patches (my last rebase was back in August on 5.2, and the panel was working correctly at 60Hz back then). Looked at it again and it does look like your glmark was vsynced (glmark explicitly disables vsync so I guess yo

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
modetest should be printing "freq: 60.0Hz", so definitely something wrong there. Though I guess you have another problem since I would expect the patch to drop it to 30 and not 13.5. (FYI glmark-x11 isn't vsynced which is why I specifically mentioned glmark-drm) On 3/3/20 9:16 PM, Brian Masn

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Brian Masney
On Tue, Mar 03, 2020 at 09:27:50PM -0500, Jonathan Marek wrote: > modetest should be printing "freq: 60.0Hz", so definitely something wrong > there. Though I guess you have another problem since I would expect the > patch to drop it to 30 and not 13.5. > > (FYI glmark-x11 isn't vsynced which is wh

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Brian Masney
On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: > Hi, > > This is a command mode panel and the the msm/mdp5 driver uses the vrefresh > field for the actual refresh rate, while the dotclock field is used for the > DSI clocks. The dotclock needed to be a bit higher than necessary oth

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
On 3/2/20 10:13 PM, Brian Masney wrote: On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: Hi, This is a command mode panel and the the msm/mdp5 driver uses the vrefresh field for the actual refresh rate, while the dotclock field is used for the DSI clocks. The dotclock needed to

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
Hi, This is a command mode panel and the the msm/mdp5 driver uses the vrefresh field for the actual refresh rate, while the dotclock field is used for the DSI clocks. The dotclock needed to be a bit higher than necessary otherwise the panel would not work. If you want to get rid of the separ

Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-03 Thread Jonathan Marek
Another thing: did you verify that the panel still runs at 60hz (and not dropping frames to 30hz)? IIRC that was the behavior with lower clock. On 3/2/20 10:28 PM, Jonathan Marek wrote: On 3/2/20 10:13 PM, Brian Masney wrote: On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: Hi

[PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7

2020-03-02 Thread Ville Syrjala
From: Ville Syrjälä The currently listed dotclock disagrees with the currently listed vrefresh rate. Change the dotclock to match the vrefresh. Someone tell me which (if either) of the dotclock or vreresh is correct? Cc: Jonathan Marek Cc: Brian Masney Cc: Linus Walleij Signed-off-by: Ville