Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Greg KH
On Thu, Jan 18, 2024 at 09:41:34AM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.01.24 um 09:32 schrieb Jiri Slaby: > > On 18. 01. 24, 9:30, Thomas Zimmermann wrote: > > > Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE): > > > > There are VESA blanking constants defined in console.h already. So us

Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Jiri Slaby
On 18. 01. 24, 9:41, Thomas Zimmermann wrote: Is it hard to get a new UAPI header accepted (honest question)? Not at all, IMO. The header just needs to be correctâ„¢ as it would be set in stone once released. thanks, -- js suse labs

Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Thomas Zimmermann
Hi Am 18.01.24 um 09:32 schrieb Jiri Slaby: On 18. 01. 24, 9:30, Thomas Zimmermann wrote: Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE): There are VESA blanking constants defined in console.h already. So use them in the console code instead of constant values. These constants also exist in

Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Jiri Slaby
On 18. 01. 24, 9:30, Thomas Zimmermann wrote: Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE): There are VESA blanking constants defined in console.h already. So use them in the console code instead of constant values. These constants also exist in include/uapi/linux/fb.h. It would be nice to

Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Thomas Zimmermann
Hi Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE): There are VESA blanking constants defined in console.h already. So use them in the console code instead of constant values. These constants also exist in include/uapi/linux/fb.h. It would be nice to find a common header where they can be shar

[PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-17 Thread Jiri Slaby (SUSE)
There are VESA blanking constants defined in console.h already. So use them in the console code instead of constant values. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: "James E.J. Bottomley" Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-par...@vger.kern