[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

2016-02-26 Thread Laurent Pinchart
Hi Tomi, On Friday 26 February 2016 11:12:21 Tomi Valkeinen wrote: > On 26/02/16 10:55, Laurent Pinchart wrote: > >> I don't quite understand what you mean. The checks apply to all planes. > > > > My point is that if you add a check to ensure that the pitch is identical > > in all planes, the oth

[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

2016-02-26 Thread Tomi Valkeinen
On 26/02/16 10:55, Laurent Pinchart wrote: >> I don't quite understand what you mean. The checks apply to all planes. > > My point is that if you add a check to ensure that the pitch is identical in > all planes, the other tests on the pitch don't have to be repeated for every > plane. Hmm..

[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

2016-02-26 Thread Laurent Pinchart
Hi Tomi, On Thursday 25 February 2016 17:56:57 Tomi Valkeinen wrote: > On 24/02/16 01:02, Laurent Pinchart wrote: > > On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote: > >> The DSS hardware uses the same ROW_INC value for both Y and UV planes > >> for NV12 format. This means that the pitch

[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

2016-02-25 Thread Tomi Valkeinen
On 24/02/16 01:02, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote: >> The DSS hardware uses the same ROW_INC value for both Y and UV planes >> for NV12 format. This means that the pitches of the Y and UV planes have >>

[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

2016-02-24 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote: > The DSS hardware uses the same ROW_INC value for both Y and UV planes > for NV12 format. This means that the pitches of the Y and UV planes have > to match. omapdrm doesn't check this at the moment, and

[PATCH 30/33] drm/omap: verify that fb plane pitches are the same

2016-02-19 Thread Tomi Valkeinen
The DSS hardware uses the same ROW_INC value for both Y and UV planes for NV12 format. This means that the pitches of the Y and UV planes have to match. omapdrm doesn't check this at the moment, and this can lead into a broken NV12 fb on the screen. This patch adds the check. Signed-off-by: Tomi