Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Kieran Bingham
Hi Laurent, On 04/12/2020 22:01, Laurent Pinchart wrote: > The encoder->name field can never be non-null in the error path, as that > can only be possible after a successful call to > drm_simple_encoder_init(). Drop the cleanup. Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > -

Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Laurent Pinchart
Hi Jacopo, On Mon, Dec 14, 2020 at 11:11:08AM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:33AM +0200, Laurent Pinchart wrote: > > The encoder->name field can never be non-null in the error path, as that > > can only be possible after a successful call to > > drm_simple_encoder_init(

Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-14 Thread Jacopo Mondi
Hi Laurent, On Sat, Dec 05, 2020 at 12:01:33AM +0200, Laurent Pinchart wrote: > The encoder->name field can never be non-null in the error path, as that > can only be possible after a successful call to > drm_simple_encoder_init(). Drop the cleanup. > > Signed-off-by: Laurent Pinchart > --- > dr

[PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path

2020-12-04 Thread Laurent Pinchart
The encoder->name field can never be non-null in the error path, as that can only be possible after a successful call to drm_simple_encoder_init(). Drop the cleanup. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 + 1 file changed, 1 insertion(+), 4 deletio