Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-25 Thread Keith Zhao
On 2023/7/25 11:12, Keith Zhao wrote: > > > On 2023/6/7 16:53, Lucas Stach wrote: >> Hi Keith, >> >> Am Freitag, dem 02.06.2023 um 15:40 +0800 schrieb Keith Zhao: >>> Add a basic platform driver of the DRM driver for JH7110 SoC. >>> >>> Signed-off-by: Keith Zhao >>> --- >>> MAINTAINERS

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-24 Thread Keith Zhao
On 2023/6/7 16:53, Lucas Stach wrote: > Hi Keith, > > Am Freitag, dem 02.06.2023 um 15:40 +0800 schrieb Keith Zhao: >> Add a basic platform driver of the DRM driver for JH7110 SoC. >> >> Signed-off-by: Keith Zhao >> --- >> MAINTAINERS | 2 + >> drivers/gpu/drm/Kcon

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-13 Thread Nicolas Dufresne
Le samedi 08 juillet 2023 à 21:11 +0200, Thomas Zimmermann a écrit : > Hi > > Am 07.07.23 um 20:09 schrieb Nicolas Dufresne: > [...] > > > > +config DRM_VERISILICON > > > > + tristate "DRM Support for VeriSilicon" > > > > > > Can you rename the driver and files? 'VeriSilicon' seems > > > un

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-08 Thread Thomas Zimmermann
Hi Am 07.07.23 um 20:09 schrieb Nicolas Dufresne: [...] +config DRM_VERISILICON + tristate "DRM Support for VeriSilicon" Can you rename the driver and files? 'VeriSilicon' seems unpronounceable. Simply 'StarFive' and starfive/ would be fine. Are you sure you want to request this ? If t

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-07 Thread Nicolas Dufresne
Hi Thomas, Le lundi 19 juin 2023 à 14:59 +0200, Thomas Zimmermann a écrit : > Hi, > > I appreciate that you split the driver into small patches. Please find > some comments below. > > Am 02.06.23 um 09:40 schrieb Keith Zhao: > > Add a basic platform driver of the DRM driver for JH7110 SoC. > >

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-03 Thread Keith Zhao
On 2023/7/4 2:42, Shengyu Qu wrote: > Hello Keith, > > While compiling this driver as a module, a error happens: > > drivers/gpu/drm/verisilicon/vs_drm: struct of_device_id is 200 bytes.  The > last of 1 is: > 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 > 0x00

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-07-03 Thread Shengyu Qu
Hello Keith, While compiling this driver as a module, a error happens: drivers/gpu/drm/verisilicon/vs_drm: struct of_device_id is 200 bytes.  The last of 1 is: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-06-19 Thread Thomas Zimmermann
Hi, I appreciate that you split the driver into small patches. Please find some comments below. Am 02.06.23 um 09:40 schrieb Keith Zhao: Add a basic platform driver of the DRM driver for JH7110 SoC. Signed-off-by: Keith Zhao --- MAINTAINERS | 2 + drivers/gpu/d

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-06-07 Thread Lucas Stach
Hi Keith, Am Freitag, dem 02.06.2023 um 15:40 +0800 schrieb Keith Zhao: > Add a basic platform driver of the DRM driver for JH7110 SoC. > > Signed-off-by: Keith Zhao > --- > MAINTAINERS | 2 + > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile

[PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-06-02 Thread Keith Zhao
Add a basic platform driver of the DRM driver for JH7110 SoC. Signed-off-by: Keith Zhao --- MAINTAINERS | 2 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/verisilicon/Kconfig | 13 ++ drivers/gpu/drm/ver