Re: [PATCH 3/7] drm/msm: a5xx: fix possible object reference leak

2019-04-10 Thread Jordan Crouse
On Thu, Apr 04, 2019 at 12:04:11AM +0800, Wen Yang wrote: > The call to of_get_child_by_name returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > drivers/gpu/drm/msm/adreno/a5xx_g

[PATCH 3/7] drm/msm: a5xx: fix possible object reference leak

2019-04-04 Thread Wen Yang
The call to of_get_child_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/gpu/drm/msm/adreno/a5xx_gpu.c:57:2-8: ERROR: missing of_node_put; acquired a node pointer with