[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Fri, May 24, 2013 at 7:06 PM, Ville Syrj?l? wrote: > On Fri, May 24, 2013 at 05:14:40PM +0200, Daniel Vetter wrote: >> On Fri, May 24, 2013 at 11:59 AM, Ville Syrj?l? >> wrote: >> > >> >> Why exactly do we need special driver callbacks for all this? Strictly >> >> speaking fbcon is just anothe

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Ville Syrjälä
On Fri, May 24, 2013 at 05:14:40PM +0200, Daniel Vetter wrote: > On Fri, May 24, 2013 at 11:59 AM, Ville Syrj?l? > wrote: > > > >> Why exactly do we need special driver callbacks for all this? Strictly > >> speaking fbcon is just another kms client, if it needs to dig around in > >> driver details

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Fri, May 24, 2013 at 11:59 AM, Ville Syrj?l? wrote: > >> Why exactly do we need special driver callbacks for all this? Strictly >> speaking fbcon is just another kms client, if it needs to dig around in >> driver details that just means our interfaces are not good enough. I know >> that there's

Re: [PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Fri, May 24, 2013 at 7:06 PM, Ville Syrjälä wrote: > On Fri, May 24, 2013 at 05:14:40PM +0200, Daniel Vetter wrote: >> On Fri, May 24, 2013 at 11:59 AM, Ville Syrjälä >> wrote: >> > >> >> Why exactly do we need special driver callbacks for all this? Strictly >> >> speaking fbcon is just anothe

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Ville Syrjälä
On Fri, May 24, 2013 at 11:35:07AM +0200, Daniel Vetter wrote: > On Wed, May 08, 2013 at 12:55:18PM +0300, ville.syrjala at linux.intel.com > wrote: > > From: Ville Syrj?l? > > > > plane->enabled is never set, so this code didn't do anything. > > > > If we end up doing a full modeset, sprites a

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Wed, May 08, 2013 at 12:55:18PM +0300, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > plane->enabled is never set, so this code didn't do anything. > > If we end up doing a full modeset, sprites already get disabled. However > if we end up doing a simple set_base, we still

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Wed, May 08, 2013 at 12:55:18PM +0300, ville.syrjala at linux.intel.com wrote: > From: Ville Syrj?l? > > plane->enabled is never set, so this code didn't do anything. > > If we end up doing a full modeset, sprites already get disabled. However > if we end up doing a simple set_base, we still

Re: [PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Ville Syrjälä
On Fri, May 24, 2013 at 05:14:40PM +0200, Daniel Vetter wrote: > On Fri, May 24, 2013 at 11:59 AM, Ville Syrjälä > wrote: > > > >> Why exactly do we need special driver callbacks for all this? Strictly > >> speaking fbcon is just another kms client, if it needs to dig around in > >> driver details

Re: [PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Fri, May 24, 2013 at 11:59 AM, Ville Syrjälä wrote: > >> Why exactly do we need special driver callbacks for all this? Strictly >> speaking fbcon is just another kms client, if it needs to dig around in >> driver details that just means our interfaces are not good enough. I know >> that there's

Re: [PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Ville Syrjälä
On Fri, May 24, 2013 at 11:35:07AM +0200, Daniel Vetter wrote: > On Wed, May 08, 2013 at 12:55:18PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > plane->enabled is never set, so this code didn't do anything. > > > > If we end up doing a full modeset, sprites already

Re: [PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Wed, May 08, 2013 at 12:55:18PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > plane->enabled is never set, so this code didn't do anything. > > If we end up doing a full modeset, sprites already get disabled. However > if we end up doing a simple set_base, we still nee

Re: [PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-24 Thread Daniel Vetter
On Wed, May 08, 2013 at 12:55:18PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > plane->enabled is never set, so this code didn't do anything. > > If we end up doing a full modeset, sprites already get disabled. However > if we end up doing a simple set_base, we still nee

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-08 Thread ville.syrj...@linux.intel.com
From: Ville Syrj?l? plane->enabled is never set, so this code didn't do anything. If we end up doing a full modeset, sprites already get disabled. However if we end up doing a simple set_base, we still need to turn off the sprites manually. And do the same for cursors, since we only want to see

[PATCH 3/7] drm/i915: Fix fbdev sprite disable code

2013-05-08 Thread ville . syrjala
From: Ville Syrjälä plane->enabled is never set, so this code didn't do anything. If we end up doing a full modeset, sprites already get disabled. However if we end up doing a simple set_base, we still need to turn off the sprites manually. And do the same for cursors, since we only want to see