Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-21 Thread Matthew Auld
On Wed, 21 Jul 2021 at 16:47, Jason Ekstrand wrote: > > On Wed, Jul 21, 2021 at 3:25 AM Matthew Auld > wrote: > > > > On Tue, 20 Jul 2021 at 23:04, Jason Ekstrand wrote: > > > > > > On Tue, Jul 20, 2021 at 4:35 AM Matthew Auld > > > wrote: > > > > > > > > On Thu, 15 Jul 2021 at 23:39, Jason Eks

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-21 Thread Jason Ekstrand
On Wed, Jul 21, 2021 at 3:25 AM Matthew Auld wrote: > > On Tue, 20 Jul 2021 at 23:04, Jason Ekstrand wrote: > > > > On Tue, Jul 20, 2021 at 4:35 AM Matthew Auld > > wrote: > > > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > > > > > Instead of hand-rolling the same three call

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-21 Thread Matthew Auld
On Tue, 20 Jul 2021 at 23:04, Jason Ekstrand wrote: > > On Tue, Jul 20, 2021 at 4:35 AM Matthew Auld > wrote: > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > > > Instead of hand-rolling the same three calls in each function, pull them > > > into an i915_gem_object_create_user

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-20 Thread Jason Ekstrand
On Tue, Jul 20, 2021 at 4:35 AM Matthew Auld wrote: > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > Instead of hand-rolling the same three calls in each function, pull them > > into an i915_gem_object_create_user helper. Apart from re-ordering of > > the placements array ENOMEM c

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-20 Thread Matthew Auld
On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > Instead of hand-rolling the same three calls in each function, pull them > into an i915_gem_object_create_user helper. Apart from re-ordering of > the placements array ENOMEM check, the only functional change here > should be that i915_gem_d

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-16 Thread Jason Ekstrand
On Fri, Jul 16, 2021 at 6:21 AM Matthew Auld wrote: > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > Instead of hand-rolling the same three calls in each function, pull them > > into an i915_gem_object_create_user helper. Apart from re-ordering of > > the placements array ENOMEM c

Re: [PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-16 Thread Matthew Auld
On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > Instead of hand-rolling the same three calls in each function, pull them > into an i915_gem_object_create_user helper. Apart from re-ordering of > the placements array ENOMEM check, the only functional change here > should be that i915_gem_d

[PATCH 3/7] drm/i915/gem: Unify user object creation

2021-07-15 Thread Jason Ekstrand
Instead of hand-rolling the same three calls in each function, pull them into an i915_gem_object_create_user helper. Apart from re-ordering of the placements array ENOMEM check, the only functional change here should be that i915_gem_dumb_create now calls i915_gem_flush_free_objects which it proba