Re: [PATCH 3/6] drm/i915: Add a separate low-level helper for masked workarounds

2021-05-04 Thread Tvrtko Ursulin
On 01/05/2021 07:55, Lucas De Marchi wrote: On Thu, Apr 29, 2021 at 10:12:51AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We distinguish masked registers from other workarounds by the mask (clr) being zero for the former. the difference is more on the fact that those calls used _MASK

Re: [PATCH 3/6] drm/i915: Add a separate low-level helper for masked workarounds

2021-04-30 Thread Lucas De Marchi
On Thu, Apr 29, 2021 at 10:12:51AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We distinguish masked registers from other workarounds by the mask (clr) being zero for the former. the difference is more on the fact that those calls used _MASKED_* macros to prepare the upper 16 bits than

[PATCH 3/6] drm/i915: Add a separate low-level helper for masked workarounds

2021-04-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We distinguish masked registers from other workarounds by the mask (clr) being zero for the former. To avoid callers of the low-level wa_add having to know that, and be passing this zero explicitly, add a wa_masked_add low-level helper which embeds this knowledge. Signed-of