Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

Am 15.06.19 um 15:56 schrieb Daniel Vetter: On Fri, Jun 14, 2019 at 10:30 PM Daniel Vetter wrote: On Fri, Jun 14, 2019 at 08:51:11PM +0200, Christian König wrote: Am 14.06.19 um 20:24 schrieb Daniel Vetter: On Fri, Jun 14, 2019 at 8:10 PM Christian König wrote: [SNIP] WW_MUTEX_LOCK_BEGIN()

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 10:30 PM Daniel Vetter wrote: > > On Fri, Jun 14, 2019 at 08:51:11PM +0200, Christian König wrote: > > Am 14.06.19 um 20:24 schrieb Daniel Vetter: > > > > > > On Fri, Jun 14, 2019 at 8:10 PM Christian König > > > wrote: > > > > [SNIP] > > > > WW_MUTEX_LOCK_BEGIN() > > > >

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 08:51:11PM +0200, Christian König wrote: > Am 14.06.19 um 20:24 schrieb Daniel Vetter: > > > > On Fri, Jun 14, 2019 at 8:10 PM Christian König > > wrote: > > > [SNIP] > > > WW_MUTEX_LOCK_BEGIN() > > > > > > lock(lru_lock); > > > > > > while (bo = list_first(lru)) { > >

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

Am 14.06.19 um 20:24 schrieb Daniel Vetter: On Fri, Jun 14, 2019 at 8:10 PM Christian König wrote: [SNIP] WW_MUTEX_LOCK_BEGIN() lock(lru_lock); while (bo = list_first(lru)) { if (kref_get_unless_zero(bo)) { unlock(lru_lock); WW_MUTEX_LOCK(bo->ww_mutex

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 8:10 PM Christian König wrote: > > Am 14.06.19 um 17:22 schrieb Daniel Vetter: > > On Fri, Jun 14, 2019 at 03:19:16PM +0200, Peter Zijlstra wrote: > >> On Fri, Jun 14, 2019 at 02:41:22PM +0200, Christian König wrote: > >>> Use the provided macros instead of implementing

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

Am 14.06.19 um 17:22 schrieb Daniel Vetter: On Fri, Jun 14, 2019 at 03:19:16PM +0200, Peter Zijlstra wrote: On Fri, Jun 14, 2019 at 02:41:22PM +0200, Christian König wrote: Use the provided macros instead of implementing deadlock handling on our own. Signed-off-by: Christian König --- drive

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 03:19:16PM +0200, Peter Zijlstra wrote: > On Fri, Jun 14, 2019 at 02:41:22PM +0200, Christian König wrote: > > Use the provided macros instead of implementing deadlock handling on our > > own. > > > > Signed-off-by: Christian König > > --- > > drivers/gpu/drm/drm_gem.c |

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 03:06:10PM +0200, Christian König wrote: > Am 14.06.19 um 14:59 schrieb Peter Zijlstra: > > +#define ww_mutex_lock_for_each(loop, pos, contended, ret, intr, ctx) \ > > + for (contended = ERR_PTR(-ENOENT); ({ \ > > + __label__ r

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 02:41:22PM +0200, Christian König wrote: > Use the provided macros instead of implementing deadlock handling on our own. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/drm_gem.c | 49 ++- > 1 file changed, 12 insertions(+),

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

Am 14.06.19 um 14:59 schrieb Peter Zijlstra: On Fri, Jun 14, 2019 at 02:41:22PM +0200, Christian König wrote: Use the provided macros instead of implementing deadlock handling on our own. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 49 ++

Re: [PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

On Fri, Jun 14, 2019 at 02:41:22PM +0200, Christian König wrote: > Use the provided macros instead of implementing deadlock handling on our own. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/drm_gem.c | 49 ++- > 1 file changed, 12 insertions(+),

[PATCH 3/6] drm/gem: use new ww_mutex_(un)lock_for_each macros

Use the provided macros instead of implementing deadlock handling on our own. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 49 ++- 1 file changed, 12 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm