Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Gerd Hoffmann
Hi, > >>> As explained before, that would break radeon userspace on big endian > >>> hosts. > >> > >> We last discussed this about a year ago, so I hope you'll forgive my > >> lapse in memory... > >> > >> There's userspace that uses ADDFB2 with DRM_FORMAT_XRGB but > >> expects it to be host

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Ilia Mirkin
On Tue, Sep 4, 2018 at 11:02 AM, Michel Dänzer wrote: > On 2018-09-04 3:05 p.m., Ilia Mirkin wrote: >> On Tue, Sep 4, 2018 at 4:00 AM, Michel Dänzer wrote: >>> On 2018-09-03 7:07 p.m., Ilia Mirkin wrote: On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: > On Mon, Sep 03, 2018 at 12:

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Michel Dänzer
On 2018-09-04 3:05 p.m., Ilia Mirkin wrote: > On Tue, Sep 4, 2018 at 4:00 AM, Michel Dänzer wrote: >> On 2018-09-03 7:07 p.m., Ilia Mirkin wrote: >>> On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: > Userspace on big en

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Ilia Mirkin
On Tue, Sep 4, 2018 at 4:00 AM, Michel Dänzer wrote: > On 2018-09-03 7:07 p.m., Ilia Mirkin wrote: >> On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: >>> On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: Userspace on big endian machhines typically expects the ADDFB ioctl >

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-04 Thread Michel Dänzer
On 2018-09-03 7:07 p.m., Ilia Mirkin wrote: > On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: >> On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: >>> Userspace on big endian machhines typically expects the ADDFB ioctl >>> returns a big endian framebuffer. drm_mode_addfb() will

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-03 Thread Ilia Mirkin
On Mon, Sep 3, 2018 at 12:45 PM, Daniel Vetter wrote: > On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: >> Userspace on big endian machhines typically expects the ADDFB ioctl >> returns a big endian framebuffer. drm_mode_addfb() will call >> drm_mode_addfb2() unconditionally with l

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-03 Thread Michel Dänzer
On 2018-09-03 6:45 p.m., Daniel Vetter wrote: > On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: >> Userspace on big endian machhines typically expects the ADDFB ioctl >> returns a big endian framebuffer. drm_mode_addfb() will call >> drm_mode_addfb2() unconditionally with little end

Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-03 Thread Daniel Vetter
On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: > Userspace on big endian machhines typically expects the ADDFB ioctl > returns a big endian framebuffer. drm_mode_addfb() will call > drm_mode_addfb2() unconditionally with little endian DRM_FORMAT_* > values though, which is wrong.

[PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.

2018-09-03 Thread Gerd Hoffmann
Userspace on big endian machhines typically expects the ADDFB ioctl returns a big endian framebuffer. drm_mode_addfb() will call drm_mode_addfb2() unconditionally with little endian DRM_FORMAT_* values though, which is wrong. This patch fixes that. Drivers (both kernel and xorg) have quirks in p