Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-30 Thread Tomi Valkeinen
Hi Boris, On 30/10/2020 10:08, Boris Brezillon wrote: > The "propagate output flags" and soon to be added "use > timing->input_flags if present" logic should only be used as a fallback > for bridges that do not support dynamic bus format/flags negotiation > IMHO. Ideally we'd want to convert all b

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-30 Thread Tomi Valkeinen
On 30/10/2020 00:48, Laurent Pinchart wrote: >>> And, hmm... It's too easy to get confused with these, but... If the bridge >>> defines timings, and >>> timings->input_bus_flags != 0, should we always pick that, even if we got >>> something via >>> output_flags? Logic being, if this bridge defin

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-30 Thread Boris Brezillon
On Fri, 30 Oct 2020 10:40:46 +0200 Tomi Valkeinen wrote: > Hi Boris, > > On 30/10/2020 10:08, Boris Brezillon wrote: > > The "propagate output flags" and soon to be added "use > > timing->input_flags if present" logic should only be used as a fallback > > for bridges that do not support dynamic

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-30 Thread Boris Brezillon
On Fri, 30 Oct 2020 09:30:01 +0200 Tomi Valkeinen wrote: > On 30/10/2020 00:48, Laurent Pinchart wrote: > > >>> And, hmm... It's too easy to get confused with these, but... If the > >>> bridge defines timings, and > >>> timings->input_bus_flags != 0, should we always pick that, even if we got

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-29 Thread Laurent Pinchart
Hello, On Wed, Oct 28, 2020 at 08:04:53PM +0530, Nikhil Devshatwar wrote: > On 14:31-20201021, Tomi Valkeinen wrote: > > On 16/10/2020 13:39, Nikhil Devshatwar wrote: > > > When the next bridge does not specify any bus flags, use the > > > bridge->timings->input_bus_flags as fallback when propagat

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-28 Thread Nikhil Devshatwar
On 14:31-20201021, Tomi Valkeinen wrote: > On 16/10/2020 13:39, Nikhil Devshatwar wrote: > > When the next bridge does not specify any bus flags, use the > > bridge->timings->input_bus_flags as fallback when propagating > > bus flags from next bridge to current bridge. > > > > Signed-off-by: Nikhi

Re: [PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-21 Thread Tomi Valkeinen
On 16/10/2020 13:39, Nikhil Devshatwar wrote: > When the next bridge does not specify any bus flags, use the > bridge->timings->input_bus_flags as fallback when propagating > bus flags from next bridge to current bridge. > > Signed-off-by: Nikhil Devshatwar > --- > drivers/gpu/drm/drm_bridge.c |

[PATCH 3/5] drm: bridge: Propagate the bus flags from bridge->timings

2020-10-16 Thread Nikhil Devshatwar
When the next bridge does not specify any bus flags, use the bridge->timings->input_bus_flags as fallback when propagating bus flags from next bridge to current bridge. Signed-off-by: Nikhil Devshatwar --- drivers/gpu/drm/drm_bridge.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/dr