Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()

2024-02-07 Thread Laurent Pinchart
On Tue, Feb 06, 2024 at 11:45:58PM +, Kuninori Morimoto wrote: > > Hi Laurent > > Thank you for your review > > > > diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > > b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > > index 686ca8753ba2..3f8bea2e3934 100644

Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()

2024-02-06 Thread Kuninori Morimoto
Hi Laurent Thank you for your review > > diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > index 686ca8753ba2..3f8bea2e3934 100644 > > --- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c > > +++ b/drivers/

Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()

2024-02-06 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Feb 06, 2024 at 02:55:38AM +, Kuninori Morimoto wrote: > From DT point of view, in general, drivers should be asking for a > specific port number because their function is fixed in the binding. > > of_graph_get_next_endpoint() doesn't match t

[PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()

2024-02-05 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r