Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-30 Thread Ville Syrjälä
On Thu, Jan 18, 2018 at 08:42:55AM +0100, Daniel Vetter wrote: > On Wed, Jan 17, 2018 at 11:46 PM, Gurchetan Singh > wrote: > >> dma api just isn't quite sufficient for implementing fast gpu drivers. > > > > > > Can you elaborate? IIRC the DMA API has strong synchronization guarantees > > and tha

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-30 Thread Daniel Vetter
On Thu, Jan 18, 2018 at 09:20:11AM -0800, Gurchetan Singh wrote: > On Wed, Jan 17, 2018 at 11:42 PM, Daniel Vetter wrote: > > > On Wed, Jan 17, 2018 at 11:46 PM, Gurchetan Singh > > wrote: > > >> dma api just isn't quite sufficient for implementing fast gpu drivers. > > > > > > > > > Can you ela

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Gurchetan Singh
On Wed, Jan 17, 2018 at 11:42 PM, Daniel Vetter wrote: > On Wed, Jan 17, 2018 at 11:46 PM, Gurchetan Singh > wrote: > >> dma api just isn't quite sufficient for implementing fast gpu drivers. > > > > > > Can you elaborate? IIRC the DMA API has strong synchronization > guarantees > > and that ca

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 11:46 PM, Gurchetan Singh wrote: >> dma api just isn't quite sufficient for implementing fast gpu drivers. > > > Can you elaborate? IIRC the DMA API has strong synchronization guarantees > and that can be problematic for GPU drivers. However, using the DMA API for > flush

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Sean Paul
On Wed, Jan 17, 2018 at 09:31:05AM +0100, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 04:35:58PM -0800, Gurchetan Singh wrote: > > The DMA API can be used to flush scatter gather tables and physical > > pages on ARM devices. > > > > Signed-off-by: Gurchetan Singh > > --- > > drivers/gpu/drm/d

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Gurchetan Singh
> > dma api just isn't quite sufficient for implementing fast gpu drivers. Can you elaborate? IIRC the DMA API has strong synchronization guarantees and that can be problematic for GPU drivers. However, using the DMA API for flushing doesn't necessarily mean the driver has to use the rest of th

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 7:53 PM, Sean Paul wrote: > On Wed, Jan 17, 2018 at 09:31:05AM +0100, Daniel Vetter wrote: >> On Tue, Jan 16, 2018 at 04:35:58PM -0800, Gurchetan Singh wrote: >> > The DMA API can be used to flush scatter gather tables and physical >> > pages on ARM devices. >> > >> > Signe

Re: [PATCH 3/4] drm: add ARM flush implementations

2018-01-17 Thread Daniel Vetter
On Tue, Jan 16, 2018 at 04:35:58PM -0800, Gurchetan Singh wrote: > The DMA API can be used to flush scatter gather tables and physical > pages on ARM devices. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/drm_cache.c | 17 + > drivers/gpu/drm/rockchip

[PATCH 3/4] drm: add ARM flush implementations

2018-01-16 Thread Gurchetan Singh
The DMA API can be used to flush scatter gather tables and physical pages on ARM devices. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/drm_cache.c | 17 + drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 7 ++- drivers/gpu/drm/tegra/gem.c |