Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-13 Thread Daniel Vetter
On Mon, Apr 09, 2018 at 12:25:57PM +0100, Emil Velikov wrote: > On 9 April 2018 at 11:24, Emil Velikov wrote: > > On 9 April 2018 at 09:26, Daniel Vetter wrote: > > > >>> - point drm_device::dev to the parent of the virtio_device > >>> The biggest hack imaginable, if even possible. > >> > >> Wha

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-09 Thread Emil Velikov
On 9 April 2018 at 11:24, Emil Velikov wrote: > On 9 April 2018 at 09:26, Daniel Vetter wrote: > >>> - point drm_device::dev to the parent of the virtio_device >>> The biggest hack imaginable, if even possible. >> >> What would/could break if we do this? Why is this a hack? > > It _feels_ very h

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-09 Thread Emil Velikov
On 9 April 2018 at 09:26, Daniel Vetter wrote: >> - point drm_device::dev to the parent of the virtio_device >> The biggest hack imaginable, if even possible. > > What would/could break if we do this? Why is this a hack? It _feels_ very hacky to reach/store the parent of the _parent_ device giv

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-09 Thread Daniel Vetter
On Fri, Apr 06, 2018 at 01:56:15PM +0100, Emil Velikov wrote: > Hi Laszlo, > > On 6 April 2018 at 13:15, Laszlo Ersek wrote: > > On 04/04/18 19:29, Laszlo Ersek wrote: > >> Hi Emil, > >> > >> On 04/03/18 19:13, Emil Velikov wrote: > >>> On 29 March 2018 at 12:17, Laszlo Ersek wrote: > On 03

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-06 Thread Gerd Hoffmann
Hi, > What I could see as justified is a loud comment in drm_virtio_init(), > just above the call to drm_dev_set_unique(), explaining why it is > necessary to set "unique" manually. The reason is that virtio-vga > technically has "virtio_bus", not "pci_bus_type", for bus type, and so > the gener

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-06 Thread Emil Velikov
Hi Laszlo, On 6 April 2018 at 13:15, Laszlo Ersek wrote: > On 04/04/18 19:29, Laszlo Ersek wrote: >> Hi Emil, >> >> On 04/03/18 19:13, Emil Velikov wrote: >>> On 29 March 2018 at 12:17, Laszlo Ersek wrote: On 03/28/18 16:35, Emil Velikov wrote: > On 28 March 2018 at 11:27, Laszlo Ersek

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-06 Thread Laszlo Ersek
On 04/04/18 19:29, Laszlo Ersek wrote: > Hi Emil, > > On 04/03/18 19:13, Emil Velikov wrote: >> On 29 March 2018 at 12:17, Laszlo Ersek wrote: >>> On 03/28/18 16:35, Emil Velikov wrote: On 28 March 2018 at 11:27, Laszlo Ersek wrote: > On 03/28/18 03:24, Emil Velikov wrote: >>> >> Gen

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-04 Thread Laszlo Ersek
Hi Emil, On 04/03/18 19:13, Emil Velikov wrote: > On 29 March 2018 at 12:17, Laszlo Ersek wrote: >> On 03/28/18 16:35, Emil Velikov wrote: >>> On 28 March 2018 at 11:27, Laszlo Ersek wrote: On 03/28/18 03:24, Emil Velikov wrote: >> > Gents, can someone double-check this please? Just in

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-04-03 Thread Emil Velikov
On 29 March 2018 at 12:17, Laszlo Ersek wrote: > On 03/28/18 16:35, Emil Velikov wrote: >> On 28 March 2018 at 11:27, Laszlo Ersek wrote: >>> On 03/28/18 03:24, Emil Velikov wrote: > Gents, can someone double-check this please? Just in case. >>> >>> I guess I should test whether this series

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-03-29 Thread Laszlo Ersek
On 03/28/18 16:35, Emil Velikov wrote: > On 28 March 2018 at 11:27, Laszlo Ersek wrote: >> On 03/28/18 03:24, Emil Velikov wrote: >>> Gents, can someone double-check this please? Just in case. >> >> I guess I should test whether this series regresses the use case >> described in c2cbc38b97; is th

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-03-28 Thread Emil Velikov
Hi Laszlo, On 28 March 2018 at 11:27, Laszlo Ersek wrote: > On 03/28/18 03:24, Emil Velikov wrote: >> From: Emil Velikov >> >> Ealier commit a325725633c26aa66ab940f762a6b0778edf76c0 did not attribute >> that virtio can be either PCI or a platform device and removed the >> .set_busid hook. Wherea

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-03-28 Thread Laszlo Ersek
On 03/28/18 03:24, Emil Velikov wrote: > From: Emil Velikov > > Ealier commit a325725633c26aa66ab940f762a6b0778edf76c0 did not attribute > that virtio can be either PCI or a platform device and removed the > .set_busid hook. Whereas only the "platform" instance should have been > removed. > > Si

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-03-28 Thread Daniel Vetter
On Wed, Mar 28, 2018 at 02:24:50AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Ealier commit a325725633c26aa66ab940f762a6b0778edf76c0 did not attribute > that virtio can be either PCI or a platform device and removed the > .set_busid hook. Whereas only the "platform" instance should have

[PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-03-27 Thread Emil Velikov
From: Emil Velikov Ealier commit a325725633c26aa66ab940f762a6b0778edf76c0 did not attribute that virtio can be either PCI or a platform device and removed the .set_busid hook. Whereas only the "platform" instance should have been removed. Since then, two things have happened: - the driver manua