[PATCH 3/4] drm/tilcdc: add encoder slave (v2)

2013-01-29 Thread Rob Clark
Add output panel driver for i2c encoder slaves. v1: original v2: add DT bindings docs, and minor updates for review comments Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Tested-by: Koen Kooi --- .../devicetree/bindings/drm/tilcdc/slave.txt | 19 ++ drivers/gpu/drm/tilcdc/Makefil

[PATCH 3/4] drm/tilcdc: add encoder slave (v2)

2013-01-29 Thread Rob Clark
Add output panel driver for i2c encoder slaves. v1: original v2: add DT bindings docs, and minor updates for review comments Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Tested-by: Koen Kooi --- .../devicetree/bindings/drm/tilcdc/slave.txt | 19 ++ drivers/gpu/drm/tilcdc/Makefil

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: > Add output panel driver for i2c encoder slaves. > > Signed-off-by: Rob Clark Found some more stuff ... [cut] > +static const struct drm_encoder_helper_funcs slave_encoder_helper_funcs = { > + .dpms = drm_i2c_enc

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: > Add output panel driver for i2c encoder slaves. > > Signed-off-by: Rob Clark A few questions below, otherwise Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/tilcdc/Kconfig| 12 ++ > drivers/gpu/drm/tilcdc/Makefile

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 7:01 AM, Daniel Vetter wrote: > On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: >> Add output panel driver for i2c encoder slaves. >> >> Signed-off-by: Rob Clark > > Found some more stuff ... > > [cut] > >> +static const struct drm_encoder_helper_funcs slave_enc

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 6:43 AM, Daniel Vetter wrote: > On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: >> Add output panel driver for i2c encoder slaves. >> >> Signed-off-by: Rob Clark > > A few questions below, otherwise > > Reviewed-by: Daniel Vetter >> --- [snip] >> diff --git a

Re: [PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 7:01 AM, Daniel Vetter wrote: > On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: >> Add output panel driver for i2c encoder slaves. >> >> Signed-off-by: Rob Clark > > Found some more stuff ... > > [cut] > >> +static const struct drm_encoder_helper_funcs slave_enc

Re: [PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 6:43 AM, Daniel Vetter wrote: > On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: >> Add output panel driver for i2c encoder slaves. >> >> Signed-off-by: Rob Clark > > A few questions below, otherwise > > Reviewed-by: Daniel Vetter >> --- [snip] >> diff --git a

Re: [PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: > Add output panel driver for i2c encoder slaves. > > Signed-off-by: Rob Clark Found some more stuff ... [cut] > +static const struct drm_encoder_helper_funcs slave_encoder_helper_funcs = { > + .dpms = drm_i2c_enc

Re: [PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-24 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:24PM -0600, Rob Clark wrote: > Add output panel driver for i2c encoder slaves. > > Signed-off-by: Rob Clark A few questions below, otherwise Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/tilcdc/Kconfig| 12 ++ > drivers/gpu/drm/tilcdc/Makefile

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-22 Thread Rob Clark
Add output panel driver for i2c encoder slaves. Signed-off-by: Rob Clark --- drivers/gpu/drm/tilcdc/Kconfig| 12 ++ drivers/gpu/drm/tilcdc/Makefile | 1 + drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 +- drivers/gpu/drm/tilcdc/tilcdc_slave.c | 380

[PATCH 3/4] drm/tilcdc: add encoder slave

2013-01-22 Thread Rob Clark
Add output panel driver for i2c encoder slaves. Signed-off-by: Rob Clark --- drivers/gpu/drm/tilcdc/Kconfig| 12 ++ drivers/gpu/drm/tilcdc/Makefile | 1 + drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 +- drivers/gpu/drm/tilcdc/tilcdc_slave.c | 380