[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-19 Thread Daniel Vetter
On Sat, Mar 19, 2016 at 10:41:59AM +0100, Daniel Vetter wrote: > On Fri, Mar 18, 2016 at 09:16:08AM +0100, Daniel Vetter wrote: > > On Fri, Mar 18, 2016 at 01:00:26PM +0900, Michel Dänzer wrote: > > > On 17.03.2016 16:36, Daniel Vetter wrote: > > > > On Thu, Mar 17, 2016 at 06:41:14AM +1000, Dave

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-19 Thread Daniel Vetter
On Fri, Mar 18, 2016 at 09:16:08AM +0100, Daniel Vetter wrote: > On Fri, Mar 18, 2016 at 01:00:26PM +0900, Michel Dänzer wrote: > > On 17.03.2016 16:36, Daniel Vetter wrote: > > > On Thu, Mar 17, 2016 at 06:41:14AM +1000, Dave Airlie wrote: > > >> Just an aside, > > >> > > >> So is there no way to

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-18 Thread Michel Dänzer
On 17.03.2016 16:36, Daniel Vetter wrote: > On Thu, Mar 17, 2016 at 06:41:14AM +1000, Dave Airlie wrote: >> Just an aside, >> >> So is there no way to do hibernate with these blocks? >> >> Like can you not cleanly shut them down without doing a power cycle. >> >> I have to say UVD is a real pain in

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-18 Thread Daniel Vetter
On Fri, Mar 18, 2016 at 01:00:26PM +0900, Michel Dänzer wrote: > On 17.03.2016 16:36, Daniel Vetter wrote: > > On Thu, Mar 17, 2016 at 06:41:14AM +1000, Dave Airlie wrote: > >> Just an aside, > >> > >> So is there no way to do hibernate with these blocks? > >> > >> Like can you not cleanly shut th

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2016 at 06:41:14AM +1000, Dave Airlie wrote: > Just an aside, > > So is there no way to do hibernate with these blocks? > > Like can you not cleanly shut them down without doing a power cycle. > > I have to say UVD is a real pain in the ass from a stability pov, I'd > kinda wishe

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-17 Thread Dave Airlie
Just an aside, So is there no way to do hibernate with these blocks? Like can you not cleanly shut them down without doing a power cycle. I have to say UVD is a real pain in the ass from a stability pov, I'd kinda wished I'd enforced AMD creating something like intel-gpu-tools and having tests t

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Deucher, Alexander
> -Original Message- > From: Dave Airlie [mailto:airlied at gmail.com] > Sent: Wednesday, March 16, 2016 4:41 PM > To: Koenig, Christian > Cc: Jerome Glisse; Deucher, Alexander; dri-devel at lists.freedesktop.org > Subject: Re: [PATCH 3/4] drm/radeon: consolidate uvd/

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Christian König
Am 16.03.2016 um 18:43 schrieb Jerome Glisse: > On Wed, Mar 16, 2016 at 06:06:36PM +0100, Christian König wrote: >> [SNIP] >> And as I said that is exactly what you should NOT be doing here. Once the >> firmware is loaded the block should be kept in that state. >> >> Freeing the memory allocated f

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Jerome Glisse
On Wed, Mar 16, 2016 at 06:06:36PM +0100, Christian König wrote: > Am 16.03.2016 um 16:56 schrieb Jerome Glisse: > >On Wed, Mar 16, 2016 at 04:19:16PM +0100, Christian König wrote: > >>Am 16.03.2016 um 15:59 schrieb Jerome Glisse: > >>>On Wed, Mar 16, 2016 at 2:03 PM, Christian König > >>> wrote

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Christian König
Am 16.03.2016 um 16:56 schrieb Jerome Glisse: > On Wed, Mar 16, 2016 at 04:19:16PM +0100, Christian König wrote: >> Am 16.03.2016 um 15:59 schrieb Jerome Glisse: >>> On Wed, Mar 16, 2016 at 2:03 PM, Christian König >>> wrote: Am 16.03.2016 um 13:48 schrieb Jérôme Glisse: > From: Jéro

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Jerome Glisse
On Wed, Mar 16, 2016 at 04:19:16PM +0100, Christian König wrote: > Am 16.03.2016 um 15:59 schrieb Jerome Glisse: > >On Wed, Mar 16, 2016 at 2:03 PM, Christian König > > wrote: > >>Am 16.03.2016 um 13:48 schrieb Jérôme Glisse: > >>>From: Jérome Glisse > >>> > >>>This consolidate uvd/vce into a

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Christian König
Am 16.03.2016 um 15:59 schrieb Jerome Glisse: > On Wed, Mar 16, 2016 at 2:03 PM, Christian König > wrote: >> Am 16.03.2016 um 13:48 schrieb Jérôme Glisse: >>> From: Jérome Glisse >>> >>> This consolidate uvd/vce into a common shape for all generation. It >>> also leverage the rdev->has_uvd fl

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Jerome Glisse
On Wed, Mar 16, 2016 at 2:03 PM, Christian König wrote: > Am 16.03.2016 um 13:48 schrieb Jérôme Glisse: >> >> From: Jérome Glisse >> >> This consolidate uvd/vce into a common shape for all generation. It >> also leverage the rdev->has_uvd flags to know what it is useless to >> try to resume/s

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Christian König
Am 16.03.2016 um 13:48 schrieb Jérôme Glisse: > From: Jérome Glisse > > This consolidate uvd/vce into a common shape for all generation. It > also leverage the rdev->has_uvd flags to know what it is useless to > try to resume/suspend uvd/vce block. > > There is no functional changes when there

[PATCH 3/4] drm/radeon: consolidate uvd/vce initialization, resume and suspend.

2016-03-16 Thread Jérôme Glisse
From: Jérome Glisse This consolidate uvd/vce into a common shape for all generation. It also leverage the rdev->has_uvd flags to know what it is useless to try to resume/suspend uvd/vce block. There is no functional changes when there is no error. On error the device driver will behave differen