Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-15 Thread Emil Velikov
Hi Matthias, On Thu, 11 Jun 2020 at 08:54, Matthias Schiffer wrote: > On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > > + .vrefresh = 60, > > > > .vrefresh is no longer present, please drop. > > I based my patche

[PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
From: Michael Krummsdorf Add support for the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/panel/panel-simple.c | 60 +++

Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > Hi Matthias. > > Thanks, a few details you need to fix. See below. > > Sam > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > From: Michael Krummsdorf > > > > Add support for the CDTech Electronics displays

Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Sam Ravnborg
On Wed, Jun 10, 2020 at 05:26:23PM +0200, Matthias Schiffer wrote: > On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > > Hi Matthias. > > > > Thanks, a few details you need to fix. See below. > > > > Sam > > > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > >

Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-10 Thread Sam Ravnborg
Hi Matthias. Thanks, a few details you need to fix. See below. Sam On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > From: Michael Krummsdorf > > Add support for the CDTech Electronics displays S070PWS19HP-FC21 > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel