Hi Linus.
Good looking driver. A few nits in the following.
I did not try to follow the code, so no proper review done, sorry.
Sam
> +++ b/drivers/gpu/drm/mcde/mcde_display.c
> @@ -0,0 +1,1284 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2018 Linus Walleij
> + * P
On Thu, Feb 07, 2019 at 11:22:39PM +0100, Daniel Vetter wrote:
> On Thu, Feb 07, 2019 at 09:36:46AM +0100, Linus Walleij wrote:
> > +static const struct drm_mode_config_funcs mode_config_funcs = {
> > + .fb_create = drm_gem_fb_create,
>
> You need drm_gem_fb_create_with_dirty here because you ha
