[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-09 Thread Daniel Vetter
On Mon, Aug 08, 2016 at 05:25:38PM +0100, Jose Abreu wrote: > Hi, > > > On 05-08-2016 09:13, Chris Wilson wrote: > > On Fri, Aug 05, 2016 at 10:06:08AM +0200, Daniel Vetter wrote: > >> On Fri, Aug 05, 2016 at 12:01:25AM +0100, Russell King - ARM Linux wrote: > >>> On Thu, Aug 04, 2016 at 06:13:18

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-08 Thread Jose Abreu
Hi, On 05-08-2016 09:13, Chris Wilson wrote: > On Fri, Aug 05, 2016 at 10:06:08AM +0200, Daniel Vetter wrote: >> On Fri, Aug 05, 2016 at 12:01:25AM +0100, Russell King - ARM Linux wrote: >>> On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: Hi Russell, So, I didn't use fr

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-05 Thread Daniel Vetter
On Fri, Aug 05, 2016 at 12:01:25AM +0100, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: > > Hi Russell, > > > > So, I didn't use framebuffer console but used X instead and it is > > working as it should. I think we can drop this patch. I am now > > m

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-05 Thread Chris Wilson
On Fri, Aug 05, 2016 at 10:06:08AM +0200, Daniel Vetter wrote: > On Fri, Aug 05, 2016 at 12:01:25AM +0100, Russell King - ARM Linux wrote: > > On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: > > > Hi Russell, > > > > > > So, I didn't use framebuffer console but used X instead and it is

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-05 Thread Russell King - ARM Linux
On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: > Hi Russell, > > So, I didn't use framebuffer console but used X instead and it is > working as it should. I think we can drop this patch. I am now > making interoperability with DVI and I am facing the following > scenario: > - I st

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 16:04, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 03:57:21PM +0100, Jose Abreu wrote: >> Hmm, I am not debugging it right now but I remember that >> drm_fb_helper_probe_connector_modes() was not being called at the >> time I set the new EDID but only after

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Russell King - ARM Linux
On Thu, Aug 04, 2016 at 03:57:21PM +0100, Jose Abreu wrote: > Hmm, I am not debugging it right now but I remember that > drm_fb_helper_probe_connector_modes() was not being called at the > time I set the new EDID but only after I stopped sending video (I > was using modetest). Please investigate -

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 15:31, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 02:58:00PM +0100, Jose Abreu wrote: >> Hi Russell, >> >> I am not sure if this is a bug in DRM or a bad implementation of >> dw-hdmi. I've seen at least two more drivers that do the edid >> reading at the .

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Russell King - ARM Linux
On Thu, Aug 04, 2016 at 02:58:00PM +0100, Jose Abreu wrote: > Hi Russell, > > I am not sure if this is a bug in DRM or a bad implementation of > dw-hdmi. I've seen at least two more drivers that do the edid > reading at the .detect() callback: nouveau and gma500. This is > noticeable if while sendi

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 11:47, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote: >> When running HDMI compliance tests we noticed that sometimes >> the edid changes but the get_modes() function is not called >> so the edid is not updated. Moving the e

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Russell King - ARM Linux
On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote: > When running HDMI compliance tests we noticed that sometimes > the edid changes but the get_modes() function is not called > so the edid is not updated. Moving the edid reading to the > detect() callback ensures that the edid is correctl

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
When running HDMI compliance tests we noticed that sometimes the edid changes but the get_modes() function is not called so the edid is not updated. Moving the edid reading to the detect() callback ensures that the edid is correctly updated after an hotplug. Signed-off-by: Jose Abreu Cc: Carlos P