Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-20 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 07:10:56AM -0300, Melissa Wen wrote: > Hi, > > Thanks for this improvement. > > I could see that it increased the IGT test coverage, including now the > fbdev test cases. > > On 10/10, Daniel Vetter wrote: > > Hooray for generic fbdev support, making this a oneliner. We

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-16 Thread Melissa Wen
Hi, Thanks for this improvement. I could see that it increased the IGT test coverage, including now the fbdev test cases. On 10/10, Daniel Vetter wrote: > Hooray for generic fbdev support, making this a oneliner. We just > needed to fix preferred_depth fixed and the vmap support added first. I

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 01:19:38PM +0300, Pekka Paalanen wrote: > On Tue, 13 Oct 2020 09:53:44 +0200 > Daniel Vetter wrote: > > > On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > > > > > On Mon, 12 Oct 2020 16:23:35 +0200 > > > Daniel Vetter wrote: > > > > > > > On Mon, Oct 12, 2020

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Pekka Paalanen
On Tue, 13 Oct 2020 09:53:44 +0200 Daniel Vetter wrote: > On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > > > On Mon, 12 Oct 2020 16:23:35 +0200 > > Daniel Vetter wrote: > > > > > On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > > > > Hi, > > > > > > > > ... > >

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2020 at 8:14 AM Pekka Paalanen wrote: > > On Mon, 12 Oct 2020 16:23:35 +0200 > Daniel Vetter wrote: > > > On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > > > Hi, > > > > > ... > > > > It's weird because it the kernel is misconfigured and no console is > > > spec

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-12 Thread Pekka Paalanen
On Mon, 12 Oct 2020 16:23:35 +0200 Daniel Vetter wrote: > On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > > Hi, > > ... > > It's weird because it the kernel is misconfigured and no console is > > specified on the cmdline > > this console could become the main console... > >

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-12 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 02:40:58PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 13:24, Thomas Zimmermann wrote: > > Hi > > > > On Sat, 10 Oct 2020 01:21:56 +0200 Daniel Vetter > > wrote: > > > >> Hooray for generic fbdev support, making this a oneliner. We just > >> needed to fix prefer

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-12 Thread Neil Armstrong
Hi, On 12/10/2020 13:24, Thomas Zimmermann wrote: > Hi > > On Sat, 10 Oct 2020 01:21:56 +0200 Daniel Vetter > wrote: > >> Hooray for generic fbdev support, making this a oneliner. We just >> needed to fix preferred_depth fixed and the vmap support added first. >> >> Signed-off-by: Daniel Vetter

Re: [PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-12 Thread Thomas Zimmermann
Hi On Sat, 10 Oct 2020 01:21:56 +0200 Daniel Vetter wrote: > Hooray for generic fbdev support, making this a oneliner. We just > needed to fix preferred_depth fixed and the vmap support added first. > > Signed-off-by: Daniel Vetter > Cc: Rodrigo Siqueira > Cc: Melissa Wen > Cc: Haneen Mohamm

[PATCH 3/3] drm/vkms: fbdev emulation support

2020-10-09 Thread Daniel Vetter
Hooray for generic fbdev support, making this a oneliner. We just needed to fix preferred_depth fixed and the vmap support added first. Signed-off-by: Daniel Vetter Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ 1 file c