Re: [PATCH 3/3] drm/vkms: Switch to dynamic allocation for CRTC

2024-09-18 Thread Louis Chauvet
Le 17/09/24 - 18:02, José Expósito a écrit : > Hi Louis, > > Thanks for this series! > > The first 2 patches look good to me. It could make sense to move the > alloc + init pair of calls to a function (vkms_connector_init() and > vkms_encoder_init() for example), but we can always move it in the

[PATCH 3/3] drm/vkms: Switch to dynamic allocation for CRTC

2024-09-17 Thread José Expósito
Hi Louis, Thanks for this series! The first 2 patches look good to me. It could make sense to move the alloc + init pair of calls to a function (vkms_connector_init() and vkms_encoder_init() for example), but we can always move it in the furure: This one looks good, but I added couple of comment

[PATCH 3/3] drm/vkms: Switch to dynamic allocation for CRTC

2024-09-12 Thread Louis Chauvet
specific allocation for the CRTC is not strictly necessary at this point, but in order to implement dynamic configuration of VKMS (configFS), it will be easier to have one allocation per CRTC. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_crtc.c | 28 ++---