Re: [PATCH 3/3] drm/v3d: add brcm, 2712-v3d as a compatible V3D device

2023-09-29 Thread Stefan Wahren
Hi Iago, additional to Maria's comments: Please keep the order of the compatible strings. Also you need to update the device tree binding before this patch: Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml Also make sure that the series is send to the maintainers, not just dri-devel by

Re: [PATCH 3/3] drm/v3d: add brcm, 2712-v3d as a compatible V3D device

2023-09-28 Thread Maira Canal
Please, add a commit message and your s-o-b. Apart from that, Reviewed-by: Maíra Canal Best Regards, - Maíra On 9/28/23 08:45, Iago Toral Quiroga wrote: --- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3

[PATCH 3/3] drm/v3d: add brcm,2712-v3d as a compatible V3D device

2023-09-28 Thread Iago Toral Quiroga
--- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index ffbbe9d527d3..0ed2e7ba8b33 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -186,6 +186,7 @@ static const struc