Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-08-02 Thread Luben Tuikov
On 2023-08-02 00:06, Matthew Brost wrote: > On Mon, Jul 17, 2023 at 01:40:38PM -0400, Luben Tuikov wrote: >> On 2023-07-16 03:51, Asahi Lina wrote: >>> On 15/07/2023 16.14, Luben Tuikov wrote: On 2023-07-14 04:21, Asahi Lina wrote: > drm_sched_fini() currently leaves any pending jobs dangl

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-08-01 Thread Matthew Brost
On Mon, Jul 17, 2023 at 01:40:38PM -0400, Luben Tuikov wrote: > On 2023-07-16 03:51, Asahi Lina wrote: > > On 15/07/2023 16.14, Luben Tuikov wrote: > >> On 2023-07-14 04:21, Asahi Lina wrote: > >>> drm_sched_fini() currently leaves any pending jobs dangling, which > >>> causes segfaults and other b

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-20 Thread Konstantin Ryabitsev
July 18, 2023 at 1:14 AM, "Luben Tuikov" wrote: > > > Not sure about other drivers--they can speak for themselves and the CC > > > list > > > should include them--please use "dim add-missing-cc" and make sure > > > that the Git commit description contains the Cc tags--then git send-email > > >

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-19 Thread Luben Tuikov
On 2023-07-19 14:16, Konstantin Ryabitsev wrote: > July 18, 2023 at 1:14 AM, "Luben Tuikov" wrote: Not sure about other drivers--they can speak for themselves and the CC list should include them--please use "dim add-missing-cc" and make sure that the Git commit description contain

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-19 Thread Luben Tuikov
On 2023-07-19 04:45, Christian König wrote: > Am 16.07.23 um 09:51 schrieb Asahi Lina: >> On 15/07/2023 16.14, Luben Tuikov wrote: >>> On 2023-07-14 04:21, Asahi Lina wrote: drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job comp

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-19 Thread Christian König
Am 16.07.23 um 09:51 schrieb Asahi Lina: On 15/07/2023 16.14, Luben Tuikov wrote: On 2023-07-14 04:21, Asahi Lina wrote: drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are signaled after the scheduler is torn down

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-17 Thread Luben Tuikov
On 2023-07-17 18:45, Asahi Lina wrote: > On 18/07/2023 02.40, Luben Tuikov wrote: >> On 2023-07-16 03:51, Asahi Lina wrote: >>> On 15/07/2023 16.14, Luben Tuikov wrote: On 2023-07-14 04:21, Asahi Lina wrote: > drm_sched_fini() currently leaves any pending jobs dangling, which > causes

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-17 Thread Asahi Lina
On 18/07/2023 02.40, Luben Tuikov wrote: On 2023-07-16 03:51, Asahi Lina wrote: On 15/07/2023 16.14, Luben Tuikov wrote: On 2023-07-14 04:21, Asahi Lina wrote: drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are s

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-17 Thread Luben Tuikov
On 2023-07-16 03:51, Asahi Lina wrote: > On 15/07/2023 16.14, Luben Tuikov wrote: >> On 2023-07-14 04:21, Asahi Lina wrote: >>> drm_sched_fini() currently leaves any pending jobs dangling, which >>> causes segfaults and other badness when job completion fences are >>> signaled after the scheduler i

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-16 Thread Asahi Lina
On 15/07/2023 16.14, Luben Tuikov wrote: On 2023-07-14 04:21, Asahi Lina wrote: drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are signaled after the scheduler is torn down. If there are pending jobs, ideally we

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-15 Thread Luben Tuikov
On 2023-07-14 04:21, Asahi Lina wrote: > drm_sched_fini() currently leaves any pending jobs dangling, which > causes segfaults and other badness when job completion fences are > signaled after the scheduler is torn down. If there are pending jobs, ideally we want to call into the driver, so that i

[PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-14 Thread Asahi Lina
drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are signaled after the scheduler is torn down. Explicitly detach all jobs from their completion callbacks and free them. This makes it possible to write a sensible safe