[PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6

2011-10-26 Thread Ilija Hadzic
On Wed, 26 Oct 2011, Alex Deucher wrote: > > This is actually not quite right. The number of HPD (Hot Plug Detect) > pins is not equal to the number of crtcs. Radeons have supported 6 > HPD pins long before we supported 6 crtcs (e.g., cards with more > connectors than crtcs). The logic should

Re: [PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6

2011-10-26 Thread Ilija Hadzic
On Wed, 26 Oct 2011, Alex Deucher wrote: This is actually not quite right. The number of HPD (Hot Plug Detect) pins is not equal to the number of crtcs. Radeons have supported 6 HPD pins long before we supported 6 crtcs (e.g., cards with more connectors than crtcs). The logic should probab

[PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6

2011-10-26 Thread Alex Deucher
On Tue, Oct 25, 2011 at 10:40 PM, Ilija Hadzic wrote: > radeon_driver_irq_preinstall_kms and radeon_driver_irq_uninstall_kms > hard code the loop to 6 which happens to be the current maximum > number of crtcs; if one day an ASIC with more crtcs comes out, this > is a trouble waiting to happen. it'

Re: [PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6

2011-10-26 Thread Alex Deucher
On Tue, Oct 25, 2011 at 10:40 PM, Ilija Hadzic wrote: > radeon_driver_irq_preinstall_kms and radeon_driver_irq_uninstall_kms > hard code the loop to 6 which happens to be the current maximum > number of crtcs; if one day an ASIC with more crtcs comes out, this > is a trouble waiting to happen. it'

[PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6

2011-10-25 Thread Ilija Hadzic
radeon_driver_irq_preinstall_kms and radeon_driver_irq_uninstall_kms hard code the loop to 6 which happens to be the current maximum number of crtcs; if one day an ASIC with more crtcs comes out, this is a trouble waiting to happen. it's better to use num_crtc instead (for ASICs that have fewer tha

[PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6

2011-10-25 Thread Ilija Hadzic
radeon_driver_irq_preinstall_kms and radeon_driver_irq_uninstall_kms hard code the loop to 6 which happens to be the current maximum number of crtcs; if one day an ASIC with more crtcs comes out, this is a trouble waiting to happen. it's better to use num_crtc instead (for ASICs that have fewer tha