Re: [PATCH 3/3] drm/i915: Fix gt reset with GuC submission disabled

2024-04-19 Thread Nirmoy Das
Hi John, On 4/19/2024 1:38 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: Currently intel_gt_reset() happens as follows: reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET do_reset()    intel_gt_reset_all_engines() *_engine_reset_prepare() -->RESET_CTL expe

Re: [PATCH 3/3] drm/i915: Fix gt reset with GuC submission disabled

2024-04-18 Thread John Harrison
On 4/18/2024 10:10, Nirmoy Das wrote: Currently intel_gt_reset() happens as follows: reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET do_reset() intel_gt_reset_all_engines() *_engine_reset_prepare() -->RESET_CTL expects running GuC Not technically correct. There is no d

[PATCH 3/3] drm/i915: Fix gt reset with GuC submission disabled

2024-04-18 Thread Nirmoy Das
Currently intel_gt_reset() happens as follows: reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET do_reset() intel_gt_reset_all_engines() *_engine_reset_prepare() -->RESET_CTL expects running GuC *_reset_engines() intel_gt_init_hw() --> GuC comes out of GS_MIA_IN_RESET wi