[PATCH 26/27] drm/crtc-helper: disable_unused_functions really isn't for atomic

2016-06-21 Thread Laurent Pinchart
Hi Daniel, On Thursday 09 Jun 2016 10:26:44 Daniel Vetter wrote: > On Thu, Jun 09, 2016 at 01:36:30AM +0300, Laurent Pinchart wrote: > > On Wednesday 08 Jun 2016 14:19:18 Daniel Vetter wrote: > >> Rockchip just blew up here on testing, because I removed some "is this > >> crtc already disabled/ena

[PATCH 26/27] drm/crtc-helper: disable_unused_functions really isn't for atomic

2016-06-21 Thread Daniel Vetter
On Tue, Jun 21, 2016 at 12:12:54PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Thursday 09 Jun 2016 10:26:44 Daniel Vetter wrote: > > On Thu, Jun 09, 2016 at 01:36:30AM +0300, Laurent Pinchart wrote: > > > On Wednesday 08 Jun 2016 14:19:18 Daniel Vetter wrote: > > >> Rockchip just blew up h

[PATCH 26/27] drm/crtc-helper: disable_unused_functions really isn't for atomic

2016-06-09 Thread Daniel Vetter
On Thu, Jun 09, 2016 at 01:36:30AM +0300, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Wednesday 08 Jun 2016 14:19:18 Daniel Vetter wrote: > > Rockchip just blew up here on testing, because I removed some "is this > > crtc already disabled/enabled" state tracking from

[PATCH 26/27] drm/crtc-helper: disable_unused_functions really isn't for atomic

2016-06-09 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Wednesday 08 Jun 2016 14:19:18 Daniel Vetter wrote: > Rockchip just blew up here on testing, because I removed some "is this > crtc already disabled/enabled" state tracking from callbacks (not needed > with atomic). Turns out that was needed to work around r

[PATCH 26/27] drm/crtc-helper: disable_unused_functions really isn't for atomic

2016-06-08 Thread Daniel Vetter
Rockchip just blew up here on testing, because I removed some "is this crtc already disabled/enabled" state tracking from callbacks (not needed with atomic). Turns out that was needed to work around rockchip still calling legacy helper code. Since me explaining on irc/mailing-list plus kerneldoc i