Re: [PATCH 22/99] fbdev/fsl-diu-fb: Duplicate video-mode option string

2023-03-09 Thread Thomas Zimmermann
Hi Am 08.03.23 um 17:26 schrieb Timur Tabi: On Tue, Mar 7, 2023 at 2:28 AM Thomas Zimmermann wrote: So after module_init is finished, mode_option_buf[] no longer exists? Does the __init attribute on a function affect the static variables in that function? That is an excellent question. ht

Re: [PATCH 22/99] fbdev/fsl-diu-fb: Duplicate video-mode option string

2023-03-08 Thread Timur Tabi
On Tue, Mar 7, 2023 at 2:28 AM Thomas Zimmermann wrote: > > So after module_init is finished, mode_option_buf[] no longer exists? > > Does the __init attribute on a function affect the static variables in > that function? That is an excellent question. https://stackoverflow.com/questions/6455861

Re: [PATCH 22/99] fbdev/fsl-diu-fb: Duplicate video-mode option string

2023-03-07 Thread Thomas Zimmermann
Hi Am 06.03.23 um 21:04 schrieb Timur Tabi: On Mon, Mar 6, 2023 at 10:01 AM Thomas Zimmermann wrote: Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. The driver only parses the option string once as part of modul

Re: [PATCH 22/99] fbdev/fsl-diu-fb: Duplicate video-mode option string

2023-03-06 Thread Timur Tabi
On Mon, Mar 6, 2023 at 10:01 AM Thomas Zimmermann wrote: > > Assume that the driver does not own the option string or its substrings > and hence duplicate the option string for the video mode. The driver only > parses the option string once as part of module initialization, so use > a static buffe

[PATCH 22/99] fbdev/fsl-diu-fb: Duplicate video-mode option string

2023-03-06 Thread Thomas Zimmermann
Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. The driver only parses the option string once as part of module initialization, so use a static buffer to store the duplicated mode option. Linux automatically frees the