Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-26 Thread Sasha Finkelstein
On Mon, 25 Nov 2024 at 13:57, wrote: > > On 25/11/2024 12:24, Sasha Finkelstein wrote: > > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong > > wrote: > >> > >> So this controller only supports a single mode ??? > >> > > Most likely. On all devices it is connected to a single built-in display. >

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-26 Thread Sasha Finkelstein
On Mon, 25 Nov 2024 at 09:50, Neil Armstrong wrote: > > So this controller only supports a single mode ??? > Most likely. On all devices it is connected to a single built-in display. Ack on all other changes, will be fixed for v2.

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Hector Martin
On November 25, 2024 4:28:00 PM GMT+01:00, Maxime Ripard wrote: >On Mon, Nov 25, 2024 at 11:24:25PM +0900, Hector Martin wrote: >> >> >> On 2024/11/25 20:24, Sasha Finkelstein wrote: >> > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong >> > wrote: >> >> >> >> So this controller only supports a s

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread neil . armstrong
Hi Hector, On 25/11/2024 15:24, Hector Martin wrote: On 2024/11/25 20:24, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 09:50, Neil Armstrong wrote: So this controller only supports a single mode ??? Most likely. On all devices it is connected to a single built-in display. More s

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Maxime Ripard
On Mon, Nov 25, 2024 at 11:24:25PM +0900, Hector Martin wrote: > > > On 2024/11/25 20:24, Sasha Finkelstein wrote: > > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong > > wrote: > >> > >> So this controller only supports a single mode ??? > >> > > Most likely. On all devices it is connected to

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Hector Martin
On 2024/11/25 20:24, Sasha Finkelstein wrote: > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong > wrote: >> >> So this controller only supports a single mode ??? >> > Most likely. On all devices it is connected to a single built-in display. More specifically, the controller obviously support

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread neil . armstrong
On 25/11/2024 14:14, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 13:57, wrote: On 25/11/2024 12:24, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 09:50, Neil Armstrong wrote: So this controller only supports a single mode ??? Most likely. On all devices it is connected to a sin

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread neil . armstrong
On 25/11/2024 12:24, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 09:50, Neil Armstrong wrote: So this controller only supports a single mode ??? Most likely. On all devices it is connected to a single built-in display. Ack on all other changes, will be fixed for v2. OK, so instead

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Alyssa Ross
This still has the bug that I originally reported at: https://github.com/AsahiLinux/linux/issues/258 On Sun, Nov 24, 2024 at 11:29:25PM +0100, Sasha Finkelstein via B4 Relay wrote: > +static int adp_probe(struct platform_device *pdev) > +{ > + struct adp_drv_private *adp; > + int err; > +

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Jani Nikula
On Sun, 24 Nov 2024, Sasha Finkelstein via B4 Relay wrote: > diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c > new file mode 100644 > index > ..36510194e18161ef6514885c764b2e7085c587e5 > --- /dev/null > +++ b/drivers/gpu/drm/adp/

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Neil Armstrong
Hi, On 24/11/2024 23:29, Sasha Finkelstein via B4 Relay wrote: From: Sasha Finkelstein Please use "drm: " and drop gpu from commit title. This display controller is present on M-series chips and is used to drive the touchbar display. Co-developed-by: Janne Grunau Signed-off-by: Janne Gru

[PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-24 Thread Sasha Finkelstein via B4 Relay
From: Sasha Finkelstein This display controller is present on M-series chips and is used to drive the touchbar display. Co-developed-by: Janne Grunau Signed-off-by: Janne Grunau Signed-off-by: Sasha Finkelstein --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 +