Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-31 Thread Russell King - ARM Linux
On Tue, Jan 30, 2018 at 11:14:36AM +0100, Daniel Vetter wrote: > On Tue, Jan 23, 2018 at 06:56:03PM -0800, Gurchetan Singh wrote: > > The dma_cache_maint_page function is important for cache maintenance on > > ARM32 (this was determined via testing). > > > > Since we desire direct control of the c

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-30 Thread Daniel Vetter
On Tue, Jan 30, 2018 at 12:31 PM, Russell King - ARM Linux wrote: > On Tue, Jan 30, 2018 at 11:14:36AM +0100, Daniel Vetter wrote: >> On Tue, Jan 23, 2018 at 06:56:03PM -0800, Gurchetan Singh wrote: >> > The dma_cache_maint_page function is important for cache maintenance on >> > ARM32 (this was d

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-30 Thread Daniel Vetter
On Tue, Jan 23, 2018 at 06:56:03PM -0800, Gurchetan Singh wrote: > The dma_cache_maint_page function is important for cache maintenance on > ARM32 (this was determined via testing). > > Since we desire direct control of the caches in drm_cache.c, let's make > a copy of the function, rename it and

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-25 Thread Thierry Reding
On Wed, Jan 24, 2018 at 07:26:11PM +, Russell King - ARM Linux wrote: > On Wed, Jan 24, 2018 at 10:45:28AM -0800, Gurchetan Singh wrote: > > On Wed, Jan 24, 2018 at 4:45 AM, Russell King - ARM Linux < > > li...@armlinux.org.uk> wrote: > > > So no, this is not an acceptable approach. > > > > > >

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-24 Thread Gurchetan Singh
On Wed, Jan 24, 2018 at 11:26 AM, Russell King - ARM Linux wrote: > On Wed, Jan 24, 2018 at 10:45:28AM -0800, Gurchetan Singh wrote: >> On Wed, Jan 24, 2018 at 4:45 AM, Russell King - ARM Linux < >> li...@armlinux.org.uk> wrote: >> > So no, this is not an acceptable approach. >> > >> > Secondly, i

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-24 Thread Russell King - ARM Linux
On Wed, Jan 24, 2018 at 10:45:28AM -0800, Gurchetan Singh wrote: > On Wed, Jan 24, 2018 at 4:45 AM, Russell King - ARM Linux < > li...@armlinux.org.uk> wrote: > > So no, this is not an acceptable approach. > > > > Secondly, in light of spectre and meltdown, do we _really_ want to > > export cache f

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-24 Thread Russell King - ARM Linux
On Tue, Jan 23, 2018 at 06:56:03PM -0800, Gurchetan Singh wrote: > The dma_cache_maint_page function is important for cache maintenance on > ARM32 (this was determined via testing). > > Since we desire direct control of the caches in drm_cache.c, let's make > a copy of the function, rename it and

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-24 Thread Gurchetan Singh
On Wed, Jan 24, 2018 at 4:45 AM, Russell King - ARM Linux < li...@armlinux.org.uk> wrote: > On Tue, Jan 23, 2018 at 06:56:03PM -0800, Gurchetan Singh wrote: > > The dma_cache_maint_page function is important for cache maintenance on > > ARM32 (this was determined via testing). > > > > Since we des

Re: [PATCH 2/5] drm: add ARM flush implementation

2018-01-24 Thread Lucas Stach
Am Dienstag, den 23.01.2018, 18:56 -0800 schrieb Gurchetan Singh: > The dma_cache_maint_page function is important for cache maintenance on > ARM32 (this was determined via testing). > > Since we desire direct control of the caches in drm_cache.c, let's make > a copy of the function, rename it and

[PATCH 2/5] drm: add ARM flush implementation

2018-01-23 Thread Gurchetan Singh
The dma_cache_maint_page function is important for cache maintenance on ARM32 (this was determined via testing). Since we desire direct control of the caches in drm_cache.c, let's make a copy of the function, rename it and use it. v2: Don't use DMA API, call functions directly (Daniel) Signed-of