Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-05-26 Thread Hans Verkuil
Hi Arnaud, My apologies for the long delay in replying, it's been very, very busy lately. I hope I'll be able to be more responsive going forward. On 21/04/2023 18:58, Arnaud Vrac wrote: > Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit > : >> >> Hi Arnaud, >> >> Some review comments below..

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-22 Thread Arnaud Vrac
Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit : > > Hi Arnaud, > > Some review comments below... Hi Hans, For context, I first based my work on the fbdev driver from Qualcomm a few years ago, on our own CEC framework which does not implement any CEC protocol logic (as android does). At the

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-21 Thread Hans Verkuil
Hi Arnaud, Some review comments below... On 4/18/23 20:10, Arnaud Vrac wrote: > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > and MSM8998. The hardware block can handle a single CEC logical address > and broadcast messages. > > Port the CEC driver from downstream msm

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-21 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 02:20, Dmitry Baryshkov a écrit : > > On 18/04/2023 21:10, Arnaud Vrac wrote: > > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > > and MSM8998. The hardware block can handle a single CEC logical address > > and broadcast messages. > > > > Port the

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-20 Thread Dmitry Baryshkov
On Thu, 20 Apr 2023 at 10:24, Arnaud Vrac wrote: > > Le jeu. 20 avr. 2023 à 02:20, Dmitry Baryshkov > a écrit : > > > > On 18/04/2023 21:10, Arnaud Vrac wrote: > > > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > > > and MSM8998. The hardware block can handle a single

[PATCH 2/4] drm/msm: add hdmi cec support

2023-04-20 Thread Arnaud Vrac
Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 and MSM8998. The hardware block can handle a single CEC logical address and broadcast messages. Port the CEC driver from downstream msm-4.4 kernel. It has been tested on MSM8998 and passes the cec-compliance tool tests. Sign

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-19 Thread Dmitry Baryshkov
On 18/04/2023 21:10, Arnaud Vrac wrote: Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 and MSM8998. The hardware block can handle a single CEC logical address and broadcast messages. Port the CEC driver from downstream msm-4.4 kernel. It has been tested on MSM8998 and p