Re: [PATCH 2/4] drm/imx: imx-ldb: add missing of_node_puts

2019-01-17 Thread Philipp Zabel
Hi Julia, On Sun, 2019-01-13 at 09:47 +0100, Julia Lawall wrote: > The device node iterators perform an of_node_get on each > iteration, so a jump out of the loop requires an of_node_put. > > Move the initialization channel->child = child; down to just > before the call to imx_ldb_register so tha

[PATCH 2/4] drm/imx: imx-ldb: add missing of_node_puts

2019-01-13 Thread Julia Lawall
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. Move the initialization channel->child = child; down to just before the call to imx_ldb_register so that intervening failures don't need to clear it. Add a label at the end of th