Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Sebastian Hesselbarth
On 01/31/2013 03:23 PM, Rob Clark wrote: On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth wrote: On 01/29/2013 06:23 PM, Rob Clark wrote: [...] + +/* The TDA9988 series of devices use a paged register scheme.. to simplify + * things we encode the page # in upper bits of the register #.

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Russell King - ARM Linux
On Thu, Jan 31, 2013 at 08:23:53AM -0600, Rob Clark wrote: > On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth > wrote: > > On 01/29/2013 06:23 PM, Rob Clark wrote: > >> > >> Driver for the NXP TDA998X i2c hdmi encoder slave. > > > > > > Rob, > > > > good to see a driver for TDA998x comming!

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Sebastian Hesselbarth
On 01/31/2013 03:23 PM, Rob Clark wrote: > On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth > wrote: >> On 01/29/2013 06:23 PM, Rob Clark wrote: [...] >>> + >>> +/* The TDA9988 series of devices use a paged register scheme.. to >>> simplify >>> + * things we encode the page # in upper bits

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Russell King - ARM Linux
On Thu, Jan 31, 2013 at 08:23:53AM -0600, Rob Clark wrote: > On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth > wrote: > > On 01/29/2013 06:23 PM, Rob Clark wrote: > >> > >> Driver for the NXP TDA998X i2c hdmi encoder slave. > > > > > > Rob, > > > > good to see a driver for TDA998x comming!

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Rob Clark
On Thu, Jan 31, 2013 at 2:14 PM, Sebastian Hesselbarth wrote: > On 01/31/2013 03:23 PM, Rob Clark wrote: >> >> On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth >> wrote: >>> >>> On 01/29/2013 06:23 PM, Rob Clark wrote: > > [...] + +/* The TDA9988 series of devices use a page

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Rob Clark
On Thu, Jan 31, 2013 at 2:14 PM, Sebastian Hesselbarth wrote: > On 01/31/2013 03:23 PM, Rob Clark wrote: >> >> On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth >> wrote: >>> >>> On 01/29/2013 06:23 PM, Rob Clark wrote: > > [...] + +/* The TDA9988 series of devices use a page

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Rob Clark
On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth wrote: > On 01/29/2013 06:23 PM, Rob Clark wrote: >> >> Driver for the NXP TDA998X i2c hdmi encoder slave. > > > Rob, > > good to see a driver for TDA998x comming! I'd love to test > it on CuBox (mach-dove) but there is no gpu driver I can hoo

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Rob Clark
On Wed, Jan 30, 2013 at 8:23 PM, Sebastian Hesselbarth wrote: > On 01/29/2013 06:23 PM, Rob Clark wrote: >> >> Driver for the NXP TDA998X i2c hdmi encoder slave. > > > Rob, > > good to see a driver for TDA998x comming! I'd love to test > it on CuBox (mach-dove) but there is no gpu driver I can hoo

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-31 Thread Sebastian Hesselbarth
On 01/29/2013 06:23 PM, Rob Clark wrote: > Driver for the NXP TDA998X i2c hdmi encoder slave. Rob, good to see a driver for TDA998x comming! I'd love to test it on CuBox (mach-dove) but there is no gpu driver I can hook up, yet. Anyway, I will make some comments how I think the driver should be i

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-30 Thread Sebastian Hesselbarth
On 01/29/2013 06:23 PM, Rob Clark wrote: Driver for the NXP TDA998X i2c hdmi encoder slave. Rob, good to see a driver for TDA998x comming! I'd love to test it on CuBox (mach-dove) but there is no gpu driver I can hook up, yet. Anyway, I will make some comments how I think the driver should be

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-29 Thread Rob Clark
Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming v3: add Kconfig, fix dup'd MODULE_DESCRIPTION Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Tested-by: Koen Kooi --- drivers/gpu/drm/i2c/Kconfig | 6 + drivers/gpu/drm/i2c/Makefile

[PATCH 2/4] drm/i2c: nxp-tda998x (v3)

2013-01-29 Thread Rob Clark
Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming v3: add Kconfig, fix dup'd MODULE_DESCRIPTION Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Tested-by: Koen Kooi --- drivers/gpu/drm/i2c/Kconfig | 6 + drivers/gpu/drm/i2c/Makefile