Re: [PATCH 2/3] rust: alloc: add Vec::resize method

2025-03-15 Thread Miguel Ojeda
On Sat, Mar 15, 2025 at 3:43 AM Andrew Ballance wrote: > > +/// # Example Nit: please use the plural for section headers. Thanks! Cheers, Miguel

Re: [PATCH 2/3] rust: alloc: add Vec::resize method

2025-03-15 Thread Danilo Krummrich
On Fri, Mar 14, 2025 at 09:42:34PM -0500, Andrew Ballance wrote: > implemnts the equivalent of the rust std's Vec::resize > on the kernel's Vec type. Nit: It is preferred to use the imperative form, i.e. "Implement the equivalent [...]". > > Signed-off-by: Andrew Ballance > --- > rust/kernel/a

[PATCH 2/3] rust: alloc: add Vec::resize method

2025-03-15 Thread Andrew Ballance
implemnts the equivalent of the rust std's Vec::resize on the kernel's Vec type. Signed-off-by: Andrew Ballance --- rust/kernel/alloc/kvec.rs | 25 + 1 file changed, 25 insertions(+) diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs index 75e9feebb81f..c

Re: [PATCH 2/3] rust: alloc: add Vec::resize method

2025-03-15 Thread Benno Lossin
On Sat Mar 15, 2025 at 3:42 AM CET, Andrew Ballance wrote: > implemnts the equivalent of the rust std's Vec::resize > on the kernel's Vec type. > > Signed-off-by: Andrew Ballance Reviewed-by: Benno Lossin --- Cheers, Benno > --- > rust/kernel/alloc/kvec.rs | 25 + > 1