[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input

2014-06-01 Thread Tobias Jakobi
The hardware accepts scaling factors formatted in a fixed-point format. The current macro casts to integer first, then multiplies by the fp conversion factor. This does not make any sense. In particular, truly 'fractional' inputs, like 1.5, won't work that way. --- exynos/fimg2d.h | 2 +- 1 file

[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

2014-06-01 Thread Tomasz Figa
On 01.06.2014 03:14, Tobias Jakobi wrote: > Hello Tomasz! > > > Tomasz Figa wrote: >> However looking at libdrm repo history, your patches don't seem to >> follow formatting guidelines used there: they lack commit messages >> (which should say what is changed and why) and your signed-off-by tags.

[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

2014-06-01 Thread Tobias Jakobi
Hello Tomasz! Tomasz Figa wrote: > However looking at libdrm repo history, your patches don't seem to > follow formatting guidelines used there: they lack commit messages > (which should say what is changed and why) and your signed-off-by tags. Originally I sent these to Rob Clark (with Inki Dae

[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

2014-06-01 Thread Tomasz Figa
Hi Tobias, First of all, thanks for spotting those issues and sending patches. However looking at libdrm repo history, your patches don't seem to follow formatting guidelines used there: they lack commit messages (which should say what is changed and why) and your signed-off-by tags. Also it is

[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED

2014-05-29 Thread Tobias Jakobi
--- exynos/fimg2d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h index 1aac378..bc45ab5 100644 --- a/exynos/fimg2d.h +++ b/exynos/fimg2d.h @@ -25,7 +25,7 @@ #define G2D_MAX_CMD_LIST_NR64 #define G2D_PLANE_MAX_NR 2 -#define G2D_D