On Tue, Aug 25, 2015 at 9:11 PM, Rob Clark wrote:
> On Tue, Aug 25, 2015 at 3:05 AM, Daniel Vetter wrote:
>> On Wed, Aug 19, 2015 at 03:00:04PM -0400, Rob Clark wrote:
>>> On Tue, Apr 7, 2015 at 2:09 PM, Jilai Wang wrote:
>>> So one thing that I wanted sorting out before we let userspace see
>>>
On Tue, Aug 25, 2015 at 3:05 AM, Daniel Vetter wrote:
> On Wed, Aug 19, 2015 at 03:00:04PM -0400, Rob Clark wrote:
>> On Tue, Apr 7, 2015 at 2:09 PM, Jilai Wang wrote:
>> So one thing that I wanted sorting out before we let userspace see
>> streaming writeback (where I do think v4l is the right i
On Wed, Aug 19, 2015 at 03:00:04PM -0400, Rob Clark wrote:
> On Tue, Apr 7, 2015 at 2:09 PM, Jilai Wang wrote:
> So one thing that I wanted sorting out before we let userspace see
> streaming writeback (where I do think v4l is the right interface), is
> a way to deal w/ permissions/security.. Ie.
(()()
On Tue, Apr 7, 2015 at 2:09 PM, Jilai Wang wrote:
> Add writeback support in msm kms framework.
> V1: Initial change
> V2: Address Rob/Paul/Emil's comments
>
> Signed-off-by: Jilai Wang
> ---
> drivers/gpu/drm/msm/Kconfig | 10 +
> drivers/gpu/drm/msm/Makefile
> On Tue, Apr 07, 2015 at 03:55:45PM -, jilaiw at codeaurora.org wrote:
>> > On Thu, Apr 02, 2015 at 10:29:52AM -0400, Rob Clark wrote:
>> >> So, from a quick look, it seems like there is a lot of potential to
>> >> split the v4l part out into some drm helpers.. it looks pretty
>> >> generic(is
On Tue, Apr 07, 2015 at 03:55:45PM -, jilaiw at codeaurora.org wrote:
> > On Thu, Apr 02, 2015 at 10:29:52AM -0400, Rob Clark wrote:
> >> So, from a quick look, it seems like there is a lot of potential to
> >> split the v4l part out into some drm helpers.. it looks pretty
> >> generic(ish), or
> On Thu, Apr 02, 2015 at 10:29:52AM -0400, Rob Clark wrote:
>> So, from a quick look, it seems like there is a lot of potential to
>> split the v4l part out into some drm helpers.. it looks pretty
>> generic(ish), or at least it could be with some strategically placed
>> vfuncs in drm_v4l2_helper_
Add writeback support in msm kms framework.
V1: Initial change
V2: Address Rob/Paul/Emil's comments
Signed-off-by: Jilai Wang
---
drivers/gpu/drm/msm/Kconfig | 10 +
drivers/gpu/drm/msm/Makefile | 7 +
drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c
On Thu, Apr 02, 2015 at 10:29:52AM -0400, Rob Clark wrote:
> So, from a quick look, it seems like there is a lot of potential to
> split the v4l part out into some drm helpers.. it looks pretty
> generic(ish), or at least it could be with some strategically placed
> vfuncs in drm_v4l2_helper_funcs.
On 2 April 2015 at 19:07, wrote:
> Thanks Emil. Please check the comments embedded and for the rest I will
> update the code.
>
>> Hi Jilai,
>>
>> Just a few questions, not really a review as I'm not that familiar
>> with the code.
>>
>>
>>> +++ b/drivers/gpu/drm/msm/Kconfig
>>> @@ -27,6 +27,16 @
Hi Jilai,
On Thu, 2015-04-02 at 17:58 +, jilaiw at codeaurora.org wrote:
> Thanks Paul. Some comments embedded and for the rest I will update the
> code accordingly.
Most of my comments appear to be ill informed, so I wouldn't mind if
you'd specify which updates you actually plan to do.
> >>
> On Thu, Apr 2, 2015 at 2:24 PM, Paul Bolle wrote:
>> Hi Jilai,
>>
>> On Thu, 2015-04-02 at 17:58 +, jilaiw at codeaurora.org wrote:
>>> Thanks Paul. Some comments embedded and for the rest I will update the
>>> code accordingly.
>>
>> Most of my comments appear to be ill informed, so I would
> On Thu, Apr 2, 2015 at 2:24 PM, Paul Bolle wrote:
>> Hi Jilai,
>>
>> On Thu, 2015-04-02 at 17:58 +, jilaiw at codeaurora.org wrote:
>>> Thanks Paul. Some comments embedded and for the rest I will update the
>>> code accordingly.
>>
>> Most of my comments appear to be ill informed, so I would
Thanks Emil. Please check the comments embedded and for the rest I will
update the code.
> Hi Jilai,
>
> Just a few questions, not really a review as I'm not that familiar
> with the code.
>
>
>> +++ b/drivers/gpu/drm/msm/Kconfig
>> @@ -27,6 +27,16 @@ config DRM_MSM_FBDEV
>> support. Not
Thanks Paul. Some comments embedded and for the rest I will update the
code accordingly.
> A few nits follow.
>
> On Wed, 2015-04-01 at 17:12 -0400, Jilai Wang wrote:
>> --- a/drivers/gpu/drm/msm/Kconfig
>> +++ b/drivers/gpu/drm/msm/Kconfig
>
>> +config DRM_MSM_WB
>> +bool "Enable writeback su
On Thu, Apr 2, 2015 at 2:24 PM, Paul Bolle wrote:
> Hi Jilai,
>
> On Thu, 2015-04-02 at 17:58 +, jilaiw at codeaurora.org wrote:
>> Thanks Paul. Some comments embedded and for the rest I will update the
>> code accordingly.
>
> Most of my comments appear to be ill informed, so I wouldn't mind
On Thu, Apr 2, 2015 at 2:07 PM, wrote:
>>> +config DRM_MSM_WB
>>> + bool "Enable writeback support for MSM modesetting driver"
>>> + depends on DRM_MSM
>>> + depends on VIDEO_V4L2
>>> + select VIDEOBUF2_CORE
>>> + default y
>>> + help
>>> + Choose this
Hi Jilai,
Just a few questions, not really a review as I'm not that familiar
with the code.
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -27,6 +27,16 @@ config DRM_MSM_FBDEV
> support. Note that this support also provide the linux console
> support on top of the MSM modesetting d
A few nits follow.
On Wed, 2015-04-01 at 17:12 -0400, Jilai Wang wrote:
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> +config DRM_MSM_WB
> + bool "Enable writeback support for MSM modesetting driver"
> + depends on DRM_MSM
> + depends on VIDEO_V4L2
> +
So, from a quick look, it seems like there is a lot of potential to
split the v4l part out into some drm helpers.. it looks pretty
generic(ish), or at least it could be with some strategically placed
vfuncs in drm_v4l2_helper_funcs.
I do think we need to figure out the auth/security situation. We
Add writeback support in msm kms framework.
Signed-off-by: Jilai Wang
---
drivers/gpu/drm/msm/Kconfig | 10 +
drivers/gpu/drm/msm/Makefile | 9 +-
drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 10 +
drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.h
21 matches
Mail list logo
