Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-06 Thread Maxime Ripard
On Tue, Nov 03, 2020 at 06:28:24PM +0200, Ville Syrjälä wrote: > On Tue, Nov 03, 2020 at 05:15:51PM +0100, Maxime Ripard wrote: > > Hi Ville, > > > > On Mon, Nov 02, 2020 at 06:04:06PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 02, 2020 at 02:38:33PM +0100, Maxime Ripard wrote: > > > > Many dri

Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-05 Thread Ville Syrjälä
On Thu, Nov 05, 2020 at 05:35:28PM +0100, Maxime Ripard wrote: > On Tue, Nov 03, 2020 at 06:28:24PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 03, 2020 at 05:15:51PM +0100, Maxime Ripard wrote: > > > Hi Ville, > > > > > > On Mon, Nov 02, 2020 at 06:04:06PM +0200, Ville Syrjälä wrote: > > > > On M

Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-04 Thread Maxime Ripard
Hi Ville, On Mon, Nov 02, 2020 at 06:04:06PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2020 at 02:38:33PM +0100, Maxime Ripard wrote: > > Many drivers reference the crtc->pointer in order to get the current CRTC > > state in their atomic_begin or atomic_flush hooks, which would be the new > >

Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-03 Thread Ville Syrjälä
On Tue, Nov 03, 2020 at 05:15:51PM +0100, Maxime Ripard wrote: > Hi Ville, > > On Mon, Nov 02, 2020 at 06:04:06PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 02, 2020 at 02:38:33PM +0100, Maxime Ripard wrote: > > > Many drivers reference the crtc->pointer in order to get the current CRTC > > > sta

Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-02 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 02:38:33PM +0100, Maxime Ripard wrote: > Many drivers reference the crtc->pointer in order to get the current CRTC > state in their atomic_begin or atomic_flush hooks, which would be the new > CRTC state in the global atomic state since _swap_state happened when those > hook

[PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-02 Thread Maxime Ripard
Many drivers reference the crtc->pointer in order to get the current CRTC state in their atomic_begin or atomic_flush hooks, which would be the new CRTC state in the global atomic state since _swap_state happened when those hooks are run. Use the drm_atomic_get_new_crtc_state helper to get that st