Re: [PATCH 2/3] drm: Introduce __setplane_atomic()

2018-06-28 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 7:36 PM, Ville Syrjälä wrote: > On Thu, Jun 28, 2018 at 07:05:10PM +0200, Daniel Vetter wrote: >> On Thu, Jun 28, 2018 at 04:54:56PM +0300, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > All the plane->fb/old_fb/crtc dance of __setplane_internal() is >> > pointles

Re: [PATCH 2/3] drm: Introduce __setplane_atomic()

2018-06-28 Thread Ville Syrjälä
On Thu, Jun 28, 2018 at 07:05:10PM +0200, Daniel Vetter wrote: > On Thu, Jun 28, 2018 at 04:54:56PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > All the plane->fb/old_fb/crtc dance of __setplane_internal() is > > pointless on atomic drivers. So let's just introduce a simpler > > ve

Re: [PATCH 2/3] drm: Introduce __setplane_atomic()

2018-06-28 Thread Daniel Vetter
On Thu, Jun 28, 2018 at 04:54:56PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > All the plane->fb/old_fb/crtc dance of __setplane_internal() is > pointless on atomic drivers. So let's just introduce a simpler > version that skips all that. > > Ideally we could also skip the __setplane_c

[PATCH 2/3] drm: Introduce __setplane_atomic()

2018-06-28 Thread Ville Syrjala
From: Ville Syrjälä All the plane->fb/old_fb/crtc dance of __setplane_internal() is pointless on atomic drivers. So let's just introduce a simpler version that skips all that. Ideally we could also skip the __setplane_check() as drm_atomic_plane_check() already checks for everything, but the leg