Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas: >> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, >> so lets relax this in the driver and make the reset GPIO to be optional. >> >> The devm_gpiod_get_optional() helper is similar

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi > > Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas: >> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, >> so lets relax this in the driver and make the reset GPIO to be optional. >> >> The devm_gpiod_get_optional() he

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-14 Thread Thomas Zimmermann
Hi Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas: Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, so lets relax this in the driver and make the reset GPIO to be optional. The devm_gpiod_get_optional() helper is similar to devm_gpiod_get(), but returns NULL whe

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-14 Thread Thomas Zimmermann
Hi Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas: Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, so lets relax this in the driver and make the reset GPIO to be optional. The devm_gpiod_get_optional() helper is similar to devm_gpiod_get(), but returns NULL whe

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-11 Thread Javier Martinez Canillas
Marcus Folkesson writes: Hello Marcus, > Hello Javier, > > On Thu, Jul 10, 2025 at 01:00:41PM +0200, Javier Martinez Canillas wrote: >> > >> > devm_gpiod_get_optional() returns -ENOENT when the GPIO is not found, >> > and that is no error we want to propagage upwards. >> > >> > Maybe something l

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Marcus Folkesson
Hello Javier, On Thu, Jul 10, 2025 at 01:00:41PM +0200, Javier Martinez Canillas wrote: > > > > devm_gpiod_get_optional() returns -ENOENT when the GPIO is not found, > > and that is no error we want to propagage upwards. > > > > Maybe something like this instead: > > if (IS_ERR(st7571->reset) && I

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Javier Martinez Canillas
Marcus Folkesson writes: Hello Marcus, Thanks for your feedback. > On Thu, Jul 10, 2025 at 12:24:34PM +0200, Javier Martinez Canillas wrote: >> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, >> so lets relax this in the driver and make the reset GPIO to be optional.

Re: [PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Marcus Folkesson
On Thu, Jul 10, 2025 at 12:24:34PM +0200, Javier Martinez Canillas wrote: > Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, > so lets relax this in the driver and make the reset GPIO to be optional. > > The devm_gpiod_get_optional() helper is similar to devm_gpiod_get(),

[PATCH 2/3] drm/sitronix/st7571-i2c: Make the reset GPIO to be optional

2025-07-10 Thread Javier Martinez Canillas
Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin, so lets relax this in the driver and make the reset GPIO to be optional. The devm_gpiod_get_optional() helper is similar to devm_gpiod_get(), but returns NULL when there isn't a reset-gpios property defined in a DT node. T