Re: [PATCH 2/3] drm/msm: Expand UBWC config setting

2024-07-02 Thread Connor Abbott
On Tue, Jul 2, 2024 at 3:31 PM Rob Clark wrote: > > On Tue, Jul 2, 2024 at 5:56 AM Connor Abbott wrote: > > > > According to downstream we should be setting RBBM_NC_MODE_CNTL to a > > non-default value on a663 and a680, we don't support a663 and on a680 > > we're leaving it at the wrong (suboptim

Re: [PATCH 2/3] drm/msm: Expand UBWC config setting

2024-07-02 Thread Rob Clark
On Tue, Jul 2, 2024 at 5:56 AM Connor Abbott wrote: > > According to downstream we should be setting RBBM_NC_MODE_CNTL to a > non-default value on a663 and a680, we don't support a663 and on a680 > we're leaving it at the wrong (suboptimal) value. Just set it on all > GPUs. Similarly, plumb throug

[PATCH 2/3] drm/msm: Expand UBWC config setting

2024-07-02 Thread Connor Abbott
According to downstream we should be setting RBBM_NC_MODE_CNTL to a non-default value on a663 and a680, we don't support a663 and on a680 we're leaving it at the wrong (suboptimal) value. Just set it on all GPUs. Similarly, plumb through level2_swizzling_dis which will be necessary on a663. ubwc_m