Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Andrey Grodzovsky
On 2022-03-18 13:22, Rob Clark wrote: On Fri, Mar 18, 2022 at 9:27 AM Andrey Grodzovsky wrote: On 2022-03-18 12:20, Rob Clark wrote: On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky wrote: On 2022-03-17 16:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky wrote:

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Rob Clark
On Fri, Mar 18, 2022 at 9:27 AM Andrey Grodzovsky wrote: > > > On 2022-03-18 12:20, Rob Clark wrote: > > On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 16:35, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky > >>> wrote: > On 20

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Andrey Grodzovsky
On 2022-03-18 12:20, Rob Clark wrote: On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky wrote: On 2022-03-17 16:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky wrote: On 2022-03-17 14:25, Rob Clark wrote: On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky wrote:

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Rob Clark
On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky wrote: > > > On 2022-03-17 16:35, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 14:25, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky > >>> wrote: > On 2

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Andrey Grodzovsky
On 2022-03-17 16:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky wrote: On 2022-03-17 14:25, Rob Clark wrote: On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky wrote: On 2022-03-17 13:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: A

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky wrote: > > > On 2022-03-17 14:25, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 13:35, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 9:45 AM Christian König > >>> wrote: > Am 17.

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 14:25, Rob Clark wrote: On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky wrote: On 2022-03-17 13:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: Am

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky wrote: > > > On 2022-03-17 13:35, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 9:45 AM Christian König > > wrote: > >> Am 17.03.22 um 17:18 schrieb Rob Clark: > >>> On Thu, Mar 17, 2022 at 9:04 AM Christian König > >>> wrote: > Am 17.03.22

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 13:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what thi

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 12:04, Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what this patch is trying to address, so we aren't racing between shutting down the hw and the scheduler shoveling more jobs at us. Well exactly that's the

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: > > Am 17.03.22 um 17:18 schrieb Rob Clark: > > On Thu, Mar 17, 2022 at 9:04 AM Christian König > > wrote: > >> Am 17.03.22 um 16:10 schrieb Rob Clark: > >>> [SNIP] > >>> userspace frozen != kthread frozen .. that is what this patch is > >>>

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 05:44:57PM +0100, Christian König wrote: > Am 17.03.22 um 17:18 schrieb Rob Clark: > > On Thu, Mar 17, 2022 at 9:04 AM Christian König > > wrote: > > > Am 17.03.22 um 16:10 schrieb Rob Clark: > > > > [SNIP] > > > > userspace frozen != kthread frozen .. that is what this pat

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Christian König
Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what this patch is trying to address, so we aren't racing between shutting down the hw and the scheduler s

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: > > Am 17.03.22 um 16:10 schrieb Rob Clark: > > [SNIP] > > userspace frozen != kthread frozen .. that is what this patch is > > trying to address, so we aren't racing between shutting down the hw > > and the scheduler shoveling more jobs at us

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Christian König
Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what this patch is trying to address, so we aren't racing between shutting down the hw and the scheduler shoveling more jobs at us. Well exactly that's the problem. The scheduler is supposed to shovelin

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 3:06 AM Christian König wrote: > > Am 17.03.22 um 10:59 schrieb Daniel Vetter: > > On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: > >> From: Rob Clark > >> > >> In the system suspend path, we don't want to be racing with the > >> scheduler kthreads pushing addi

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Matthew Brost
On Thu, Mar 17, 2022 at 03:06:18AM -0700, Christian König wrote: > Am 17.03.22 um 10:59 schrieb Daniel Vetter: > > On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: > >> From: Rob Clark > >> > >> In the system suspend path, we don't want to be racing with the > >> scheduler kthreads pushi

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Christian König
Am 17.03.22 um 10:59 schrieb Daniel Vetter: On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: From: Rob Clark In the system suspend path, we don't want to be racing with the scheduler kthreads pushing additional queued up jobs to the hw queue (ringbuffer). So park them first. While

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Daniel Vetter
On Thu, Mar 10, 2022 at 03:46:05PM -0800, Rob Clark wrote: > From: Rob Clark > > In the system suspend path, we don't want to be racing with the > scheduler kthreads pushing additional queued up jobs to the hw > queue (ringbuffer). So park them first. While we are at it, > move the wait for act

[PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-10 Thread Rob Clark
From: Rob Clark In the system suspend path, we don't want to be racing with the scheduler kthreads pushing additional queued up jobs to the hw queue (ringbuffer). So park them first. While we are at it, move the wait for active jobs to complete into the new system- suspend path. Signed-off-by: