Re: [PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits

2020-09-22 Thread Daniel Vetter
On Mon, Sep 21, 2020 at 07:55:42AM -0700, Rob Clark wrote: > On Mon, Sep 21, 2020 at 2:23 AM Daniel Vetter wrote: > > > > On Sat, Sep 19, 2020 at 12:37:25PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > This will allow us to more easily switch scheduling rules based on what > > > user

Re: [PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits

2020-09-21 Thread Rob Clark
On Mon, Sep 21, 2020 at 2:23 AM Daniel Vetter wrote: > > On Sat, Sep 19, 2020 at 12:37:25PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This will allow us to more easily switch scheduling rules based on what > > userspace wants. > > > > Signed-off-by: Rob Clark > > I still think switchin

Re: [PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits

2020-09-21 Thread Daniel Vetter
On Sat, Sep 19, 2020 at 12:37:25PM -0700, Rob Clark wrote: > From: Rob Clark > > This will allow us to more easily switch scheduling rules based on what > userspace wants. > > Signed-off-by: Rob Clark I still think switching to the highpriority systemwq as a start (like i915 already does) woul

Re: [PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits

2020-09-21 Thread Hillf Danton
Sat, 19 Sep 2020 12:37:25 -0700 Rob Clark wrote: > > @@ -1797,6 +1797,7 @@ int drm_atomic_helper_commit(struct drm_device *dev, >struct drm_atomic_state *state, >bool nonblock) > { > + struct kthread_worker *worker = NULL; > int

[PATCH 2/3] drm/atomic: Use kthread worker for nonblocking commits

2020-09-19 Thread Rob Clark
From: Rob Clark This will allow us to more easily switch scheduling rules based on what userspace wants. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic_helper.c | 13 include/drm/drm_atomic.h| 31 + 2 files changed, 40 insertions(+)