Re: [PATCH 2/3] drm/ast: Use TX-chip register constants

2024-09-16 Thread Jocelyn Falempe
On 16/09/2024 10:25, Thomas Zimmermann wrote: Replace magic values with named constants when reading the TX chip from VGACRD1. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 13 +++-- drivers/gpu/d

[PATCH 2/3] drm/ast: Use TX-chip register constants

2024-09-16 Thread Thomas Zimmermann
Replace magic values with named constants when reading the TX chip from VGACRD1. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c | 13 +++-- drivers/gpu/drm/ast/ast_main.c | 9 + drivers/gpu/drm/ast/ast_reg.h | 2 +- 3 files changed, 13 insertions(+), 11