Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Daniel Vetter
On Fri, Jun 12, 2020 at 08:30:40AM +0200, Thomas Zimmermann wrote: > Hi > > Am 11.06.20 um 21:23 schrieb Sam Ravnborg: > > Hi Thomas. > > > > On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: > >> All upcasting from struct drm_device to struct ast_private is now > >> performed vi

Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Thomas Zimmermann
Hi Am 11.06.20 um 19:32 schrieb Daniel Vetter: > On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: >> All upcasting from struct drm_device to struct ast_private is now >> performed via to_ast_private(). Using struct drm_device.dev_private is >> deprecated. The ast variable in ast_

Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Thomas Zimmermann
Hi Am 11.06.20 um 21:23 schrieb Sam Ravnborg: > Hi Thomas. > > On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: >> All upcasting from struct drm_device to struct ast_private is now >> performed via to_ast_private(). Using struct drm_device.dev_private is >> deprecated. > > This

Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Sam Ravnborg
Hi Thomas. On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: > All upcasting from struct drm_device to struct ast_private is now > performed via to_ast_private(). Using struct drm_device.dev_private is > deprecated. This is a simple 1:1 conversion. But some cases - I checked ast_

Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: > All upcasting from struct drm_device to struct ast_private is now > performed via to_ast_private(). Using struct drm_device.dev_private is > deprecated. The ast variable in ast_crtc_helperatomic_check() is unused, > so removed it.

[PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Thomas Zimmermann
All upcasting from struct drm_device to struct ast_private is now performed via to_ast_private(). Using struct drm_device.dev_private is deprecated. The ast variable in ast_crtc_helperatomic_check() is unused, so removed it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c |