[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-08-04 Thread Russell King - ARM Linux
On Tue, Jul 12, 2016 at 12:13:52PM +0200, Daniel Vetter wrote: > Might be better to just do a request_firmware on driver load, and > simply proceed if it's not there. That is almost never a good idea - if the driver is built-in, then the request_firmware call happens before the real rootfs is moun

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-08-04 Thread Daniel Vetter
On Thu, Aug 04, 2016 at 12:35:59PM +0200, Enric Balletbo Serra wrote: > 2016-07-12 12:13 GMT+02:00 Daniel Vetter : > > On Wed, Jun 29, 2016 at 6:31 AM, Daniel Kurtz > > wrote: > >> On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov >> gmail.com> wrote: > +static ssize_t ps8640_update_fw_store(st

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-08-04 Thread Enric Balletbo Serra
2016-07-12 12:13 GMT+02:00 Daniel Vetter : > On Wed, Jun 29, 2016 at 6:31 AM, Daniel Kurtz wrote: >> On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov >> wrote: +static ssize_t ps8640_update_fw_store(struct device *dev, + struct device_attribute *attr, >

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-07-12 Thread Daniel Vetter
On Wed, Jun 29, 2016 at 6:31 AM, Daniel Kurtz wrote: > On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov > wrote: >>> +static ssize_t ps8640_update_fw_store(struct device *dev, >>> + struct device_attribute *attr, >>> + const ch

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-06-29 Thread Daniel Kurtz
Hi Emil, One answer inline below. The rest I leave to Jitao... [snip...] On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov wrote: >> +static ssize_t ps8640_update_fw_store(struct device *dev, >> + struct device_attribute *attr, >> +

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-06-16 Thread Emil Velikov
Hi Jitao Shi, A few comments/suggestions which I hope you'll find useful. Note that I'm not an expert in the area so take them with a pinch of salt. On 2 June 2016 at 10:57, Jitao Shi wrote: > +#define WRITE_STATUS_REG_CMD 0x01 > +#define READ_STATUS_REG_CMD0x05 > +#define BUSY

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-06-14 Thread Daniel Kurtz
Hi Jitao, On Thu, Jun 2, 2016 at 5:57 PM, Jitao Shi wrote: > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > --- > Changes since v15: > - Drop drm_connector_(un)register calls from parade ps8640. >The main DR

[PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-06-02 Thread Jitao Shi
This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz --- Changes since v15: - Drop drm_connector_(un)register calls from parade ps8640. The main DRM driver mtk_drm_drv now calls drm_connector_register_all() after drm_dev_r