Re: [PATCH 2/2] vfio/pci: Remove console drivers

2023-01-03 Thread Shawn Michaels
Hi, I just upgraded my system (after 7 months) and I also lost my framebuffer on boot. At first, I thought that my computer was freezing on startup, but it turns out that it is running fine (I can SSH to it and even startx remotely), only the framebuffer stops working very early on boot:

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-12-05 Thread m...@lab.how
Hi Thomas, On Mon, Dec 5, 2022 at 3:11 AM Thomas Zimmermann wrote: > > Hi > > Am 05.12.22 um 10:32 schrieb m...@lab.how: > > I have a rtx 3070 and a 3090, I am absolutely sure I am binding vfio-pci > > to the 3090 and not the 3070. > > > > I have bound the driver in two different ways, first by p

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-12-05 Thread Thomas Zimmermann
Hi Am 05.12.22 um 10:32 schrieb m...@lab.how: I have a rtx 3070 and a 3090, I am absolutely sure I am binding vfio-pci to the 3090 and not the 3070. I have bound the driver in two different ways, first by passing the IDs to the module and alternatively by manipulating the system interface and

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-12-05 Thread m...@lab.how
I have a rtx 3070 and a 3090, I am absolutely sure I am binding vfio-pci to the 3090 and not the 3070. I have bound the driver in two different ways, first by passing the IDs to the module and alternatively by manipulating the system interface and use the override (this is what I originally had to

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-12-05 Thread Thomas Zimmermann
Hi Am 05.12.22 um 01:51 schrieb Alex Williamson: On Sat, 3 Dec 2022 17:12:38 -0700 "m...@lab.how" wrote: Hi, I hope it is ok to reply to this old thread. It is, but the only relic of the thread is the subject. For reference, the latest version of this posted is here: https://lore.kernel.

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-12-04 Thread Alex Williamson
On Sat, 3 Dec 2022 17:12:38 -0700 "m...@lab.how" wrote: > Hi, > > I hope it is ok to reply to this old thread. It is, but the only relic of the thread is the subject. For reference, the latest version of this posted is here: https://lore.kernel.org/all/20220622140134.12763-4-tzimmerm...@suse.

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-12-04 Thread m...@lab.how
Hi, I hope it is ok to reply to this old thread. Unfortunately, I found a problem only now after upgrading to 6.0. My setup has multiple GPUs (2), and I depend on EFIFB to have a working console. pre-patch behavior, when I bind the vfio-pci to my secondary GPU both the passthrough and the EFIFB k

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-10 Thread Alex Williamson
On Fri, 10 Jun 2022 09:03:15 +0200 Thomas Zimmermann wrote: > Hi > > Am 09.06.22 um 23:44 schrieb Alex Williamson: > > On Thu, 9 Jun 2022 15:41:02 -0600 > > Alex Williamson wrote: > > > >> On Thu, 9 Jun 2022 11:13:22 +0200 > >> Thomas Zimmermann wrote: > >>> > >>> Please have a look at th

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-10 Thread Thomas Zimmermann
Hi Am 09.06.22 um 23:44 schrieb Alex Williamson: On Thu, 9 Jun 2022 15:41:02 -0600 Alex Williamson wrote: On Thu, 9 Jun 2022 11:13:22 +0200 Thomas Zimmermann wrote: Please have a look at the attached patch. It moves the aperture helpers to a location common to the various possible users (D

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-09 Thread Alex Williamson
On Thu, 9 Jun 2022 15:41:02 -0600 Alex Williamson wrote: > On Thu, 9 Jun 2022 11:13:22 +0200 > Thomas Zimmermann wrote: > > > > Please have a look at the attached patch. It moves the aperture helpers > > to a location common to the various possible users (DRM, fbdev, vfio). > > The DRM interf

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-09 Thread Alex Williamson
On Thu, 9 Jun 2022 11:13:22 +0200 Thomas Zimmermann wrote: > > Please have a look at the attached patch. It moves the aperture helpers > to a location common to the various possible users (DRM, fbdev, vfio). > The DRM interfaces remain untouched for now. The patch should provide > what you ne

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-09 Thread Thomas Zimmermann
Hi Am 08.06.22 um 16:04 schrieb Alex Williamson: You shouldn't have to copy any of the implementation of the aperture helpers. If you call drm_aperture_remove_conflicting_pci_framebuffers() it should work correctly. The only reason why it requires a DRM driver structure as second argument is f

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-08 Thread Gerd Hoffmann
Hi, > You shouldn't have to copy any of the implementation of the aperture > helpers. That comes from the aperture helpers being part of drm ... > For patch 2, the most trivial workaround is to instanciate struct drm_driver > here and set the name field to 'vdev->vdev.ops->name'. In the longer

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-08 Thread Alex Williamson
Hi Thomas, On Wed, 8 Jun 2022 13:11:21 +0200 Thomas Zimmermann wrote: > Hi Alex > > Am 06.06.22 um 19:53 schrieb Alex Williamson: > > Console drivers can create conflicts with PCI resources resulting in > > userspace getting mmap failures to memory BARs. This is especially evident > > when try

Re: [PATCH 2/2] vfio/pci: Remove console drivers

2022-06-08 Thread Thomas Zimmermann
Hi Alex Am 06.06.22 um 19:53 schrieb Alex Williamson: Console drivers can create conflicts with PCI resources resulting in userspace getting mmap failures to memory BARs. This is especially evident when trying to re-use the system primary console for userspace drivers. Attempt to remove all nat

[PATCH 2/2] vfio/pci: Remove console drivers

2022-06-06 Thread Alex Williamson
Console drivers can create conflicts with PCI resources resulting in userspace getting mmap failures to memory BARs. This is especially evident when trying to re-use the system primary console for userspace drivers. Attempt to remove all nature of conflicting drivers as part of our VGA initializat