Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-16 Thread Marek Vasut
On 4/7/22 10:48, Lucas Stach wrote: [...] +static void lcdif_set_mode(struct lcdif_drm_private *lcdif, u32 bus_flags) +{ + struct drm_display_mode *m = &lcdif->crtc.state->adjusted_mode; + u32 ctrl = 0; + + if (m->flags & DRM_MODE_FLAG_PHSYNC) + ctrl |= CTRL_INV_

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-07 Thread Lucas Stach
Am Donnerstag, dem 07.04.2022 um 01:22 +0200 schrieb Marek Vasut: > On 4/4/22 14:23, Lucas Stach wrote: > > Hi Marek, > > Hi, > > > not a full review right now, just the first things that I noticed while > > playing around with this. > > > > Am Dienstag, dem 22.03.2022 um 15:28 +0100 schrieb Mar

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-06 Thread Marek Vasut
On 4/4/22 14:23, Lucas Stach wrote: Hi Marek, Hi, not a full review right now, just the first things that I noticed while playing around with this. Am Dienstag, dem 22.03.2022 um 15:28 +0100 schrieb Marek Vasut: Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-04 Thread Lucas Stach
Hi Marek, not a full review right now, just the first things that I noticed while playing around with this. Am Dienstag, dem 22.03.2022 um 15:28 +0100 schrieb Marek Vasut: > Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is > completely different from the LCDIFv3 found in i.MX2

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-01 Thread Marek Vasut
On 4/1/22 10:22, Stefan Agner wrote: On 2022-03-22 15:28, Marek Vasut wrote: Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. T

Re: [PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-04-01 Thread Stefan Agner
On 2022-03-22 15:28, Marek Vasut wrote: > Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is > completely different from the LCDIFv3 found in i.MX23 in that it has > a completely scrambled register layout compared to all previous LCDIF > variants. The new LCDIFv3 also supports 36b

[PATCH 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-03-22 Thread Marek Vasut
Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. Add a separate driver which i