[PATCH 2/2] drm: fixup error path after drm_fill_in_dev

2012-06-12 Thread Jani Nikula
On Fri, 08 Jun 2012, Daniel Vetter wrote: > Within drm_fill_in_dev we call drm_lastclose to clean up the dirt in > case of failures. But the callers of drm_fill_in_dev simply don't do > anything. Now from a cursory look drm_lastclose doesn't look like the > best cleanup function in itself, but who

Re: [PATCH 2/2] drm: fixup error path after drm_fill_in_dev

2012-06-12 Thread Jani Nikula
On Fri, 08 Jun 2012, Daniel Vetter wrote: > Within drm_fill_in_dev we call drm_lastclose to clean up the dirt in > case of failures. But the callers of drm_fill_in_dev simply don't do > anything. Now from a cursory look drm_lastclose doesn't look like the > best cleanup function in itself, but who

[PATCH 2/2] drm: fixup error path after drm_fill_in_dev

2012-06-08 Thread Daniel Vetter
Within drm_fill_in_dev we call drm_lastclose to clean up the dirt in case of failures. But the callers of drm_fill_in_dev simply don't do anything. Now from a cursory look drm_lastclose doesn't look like the best cleanup function in itself, but whom am I to judge the drm error paths. Imo before we

[PATCH 2/2] drm: fixup error path after drm_fill_in_dev

2012-06-08 Thread Daniel Vetter
Within drm_fill_in_dev we call drm_lastclose to clean up the dirt in case of failures. But the callers of drm_fill_in_dev simply don't do anything. Now from a cursory look drm_lastclose doesn't look like the best cleanup function in itself, but whom am I to judge the drm error paths. Imo before we