Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-22 Thread Liu Ying
On 10/23/2024, Marek Vasut wrote: > On 10/22/24 7:59 AM, Liu Ying wrote: > > [...] > Anyway, I don't think it is necessary to manage the clk_set_rate() function calls between this driver and mxsfb_kms or lcdif_kms because "video_pll1" clock rate is supposed to be assigned in DT...

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-22 Thread Marek Vasut
On 10/22/24 7:59 AM, Liu Ying wrote: [...] Anyway, I don't think it is necessary to manage the clk_set_rate() function calls between this driver and mxsfb_kms or lcdif_kms because "video_pll1" clock rate is supposed to be assigned in DT... I disagree with this part. I believe the assignment o

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-21 Thread Liu Ying
On 10/13/2024, Marek Vasut wrote: > On 10/11/24 8:49 AM, Liu Ying wrote: >> On 10/11/2024, Marek Vasut wrote: >>> On 10/10/24 9:15 AM, Liu Ying wrote: On 10/09/2024, Marek Vasut wrote: [...] >> Anyway, I don't think it is necessary to manage the clk_set_rate() >> function calls between this

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-12 Thread Marek Vasut
On 10/11/24 8:49 AM, Liu Ying wrote: On 10/11/2024, Marek Vasut wrote: On 10/10/24 9:15 AM, Liu Ying wrote: On 10/09/2024, Marek Vasut wrote: The LDB serializer clock operate at either x7 or x14 rate of the input Isn't it either x7 or 3.5x? Is it 3.5 for the dual-link LVDS ? Yes. static

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-10 Thread Liu Ying
On 10/11/2024, Marek Vasut wrote: > On 10/10/24 9:15 AM, Liu Ying wrote: >> On 10/09/2024, Marek Vasut wrote: >>> The LDB serializer clock operate at either x7 or x14 rate of the input >> >> Isn't it either x7 or 3.5x? > > Is it 3.5 for the dual-link LVDS ? Yes. static unsigned long fsl_ldb_link

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-10 Thread Marek Vasut
On 10/10/24 9:15 AM, Liu Ying wrote: On 10/09/2024, Marek Vasut wrote: The LDB serializer clock operate at either x7 or x14 rate of the input Isn't it either x7 or 3.5x? Is it 3.5 for the dual-link LVDS ? I don't have such a panel right now to test. [...] diff --git a/drivers/gpu/drm/brid

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-10 Thread Liu Ying
On 10/09/2024, Marek Vasut wrote: > The LDB serializer clock operate at either x7 or x14 rate of the input Isn't it either x7 or 3.5x? s/operate/operates/ > LCDIFv3 scanout engine clock. Make sure the serializer clock and their > upstream Video PLL are configured early in .mode_set to the x7 or

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-09 Thread Marek Vasut
On 10/9/24 12:27 PM, Isaac Scott wrote: On Wed, 2024-10-09 at 00:38 +0200, Marek Vasut wrote: The LDB serializer clock operate at either x7 or x14 rate of the input LCDIFv3 scanout engine clock. Make sure the serializer clock and their upstream Video PLL are configured early in .mode_set to the

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-09 Thread Isaac Scott
On Wed, 2024-10-09 at 00:38 +0200, Marek Vasut wrote: > The LDB serializer clock operate at either x7 or x14 rate of the > input > LCDIFv3 scanout engine clock. Make sure the serializer clock and > their > upstream Video PLL are configured early in .mode_set to the x7 or x14 > rate of pixel clock,

[PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-08 Thread Marek Vasut
The LDB serializer clock operate at either x7 or x14 rate of the input LCDIFv3 scanout engine clock. Make sure the serializer clock and their upstream Video PLL are configured early in .mode_set to the x7 or x14 rate of pixel clock, before LCDIFv3 .atomic_enable is called which would configure the