Re: [PATCH 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-30 Thread Boqun Feng
On Fri, Jul 30, 2021 at 04:06:44PM +0800, Desmond Cheong Zhi Xi wrote: > On 30/7/21 2:08 pm, Boqun Feng wrote: > > On Fri, Jul 30, 2021 at 12:15:15PM +0800, Desmond Cheong Zhi Xi wrote: > > > In drm_is_current_master_locked, accessing drm_file.master should be > > > protected by either drm_file.mas

Re: [PATCH 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-30 Thread Desmond Cheong Zhi Xi
On 30/7/21 2:08 pm, Boqun Feng wrote: On Fri, Jul 30, 2021 at 12:15:15PM +0800, Desmond Cheong Zhi Xi wrote: In drm_is_current_master_locked, accessing drm_file.master should be protected by either drm_file.master_lookup_lock or drm_device.master_mutex. This was previously awkward to assert with

Re: [PATCH 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-29 Thread Boqun Feng
On Fri, Jul 30, 2021 at 12:15:15PM +0800, Desmond Cheong Zhi Xi wrote: > In drm_is_current_master_locked, accessing drm_file.master should be > protected by either drm_file.master_lookup_lock or > drm_device.master_mutex. This was previously awkward to assert with > lockdep. > > Following patch ("

[PATCH 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-29 Thread Desmond Cheong Zhi Xi
In drm_is_current_master_locked, accessing drm_file.master should be protected by either drm_file.master_lookup_lock or drm_device.master_mutex. This was previously awkward to assert with lockdep. Following patch ("locking/lockdep: Provide lockdep_assert{,_once}() helpers"), this assertion is now